Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UI run action buttons #580

Merged
merged 9 commits into from
Oct 8, 2021
Merged

Added UI run action buttons #580

merged 9 commits into from
Oct 8, 2021

Conversation

ajstewart
Copy link
Contributor

@ajstewart ajstewart commented Sep 9, 2021

This adds action buttons to the run detail page to allow users to perform actions through the UI that had only been available to admins via the CLI.

Specifically users can now:

  • Delete a run.
  • Use the restore run command.
  • Generate arrow files.

Which all uses the existing django-q processing (and using the Django call_command which makes things much more straight forward).

I have tested as much as possible but they all use the same user check as the process run command so it should all be good. Probably best to test it in a dev env through with lots of users.

It also includes:

For the deletion from the UI I decided to make it so that the remove all option is used - i.e. the whole directory is removed. I thought that from the UI it made sense to remove everything. Otherwise that name of job will be forever blocked off without someone going in and removing the run directory.

Built on top of #576, that should be looked at first.

Fixes #579.

Screenshots:
Screen Shot 2021-09-09 at 19 46 01

restore-run-modal

Screen Shot 2021-09-09 at 19 46 26

Screen Shot 2021-09-09 at 19 47 35

- Added restore api call in RunViewSet.
- Added hooks file for django-q async_task hooks.
- Added restore test.
- Fixed deprecation warning in test compare_runs.
- Added hooks.py to mkdocs.
- Makes calling the command from the website much easier.
- Removed hooks.
- Reverted the restorepiperun script.
- Allowed for users to delete their runs.
- Allowed for users to generate arrow files for their run.
- Added new pipeline status of `DEL`, `Deleting`.
- Updated documentation.
- Fixed restore relations (#579).
@ajstewart ajstewart added documentation Improvements or additions to documentation enhancement New feature or request UI User Interface labels Sep 9, 2021
@ajstewart ajstewart requested a review from marxide September 9, 2021 18:55
@ajstewart ajstewart self-assigned this Sep 9, 2021
@ajstewart ajstewart linked an issue Sep 9, 2021 that may be closed by this pull request
Base automatically changed from iss575-fix-ui-rerun-error-logic to dev October 8, 2021 17:41
@ajstewart ajstewart merged commit 995590b into dev Oct 8, 2021
@ajstewart ajstewart deleted the add-ui-run-buttons branch October 8, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore run action not removing all necessary relations
2 participants