Unused imports #545 #546
Merged
Unused imports #545 #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dliptai
commented
Jun 3, 2021
dliptai
commented
- Remove unused imports
- Add linter to CICD to check for unused imports on pull requests
Closed
…so added both to CICD
|
I've also added checks for trailing whitespaces and no newlines at end of file. This opens up a larger discussion about enforcing certain formatting in general. |
shiblisaleheen
approved these changes
Jun 4, 2021
|
Just to note that the changelog was not updated with this pull request and still needs this PR added. Please remember to update it with every PR. |
This was referenced Jun 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.