Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update #471

Merged
merged 28 commits into from
Apr 1, 2021
Merged

Documentation update #471

merged 28 commits into from
Apr 1, 2021

Conversation

ajstewart
Copy link
Contributor

@ajstewart ajstewart commented Mar 11, 2021

My long promised update to the documentation. I've added text and created the following heading sections:

  • Pipeline features and design.
  • Using the Pipeline.
  • Exploring the Pipeline Website.
  • Pipeline Outputs.
  • FAQs.

I approached this as dumping as much knowledge and instruction as I could into the documentation with the view it can then be iterated and improved from this point.

Because there is a lot of change I would recommend running the mkdocs server locally and exploring it that way.

I expect there are a few spots of poor language in there in trying to get it done - please feel free to directly fix language to this branch or make suggestions to commit. Same goes for headings and layout, feel free to change it if you think something is not clear.

- Basic pages on how to use the pipeline.
- New screenshots.
- Activated MathJax
- Added template new pages.
@ajstewart ajstewart added the documentation Improvements or additions to documentation label Mar 11, 2021
@ajstewart ajstewart self-assigned this Mar 11, 2021
@ajstewart ajstewart changed the title WIP: Documentation update Documentation update Mar 19, 2021
@ajstewart ajstewart marked this pull request as ready for review March 19, 2021 00:48
@ajstewart ajstewart requested review from marxide and srggrs March 19, 2021 00:48
@ajstewart
Copy link
Contributor Author

@srggrs @marxide I have finally got to a point where I think everything is covered... See the top post in this PR for details (basically I highly recommend just running the local mkdocs server and looking through that way as it's a lot of new content - feel free to make changes direct to this branch).

One TODO: I've added a link to the docs to the pipeline navbar but I'm not sure what the link is so I've left it blank for now.

Copy link
Contributor

@srggrs srggrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't have time to go through all of it in details. Just read quickly through. Minor comments.

Well done! I think you added plenty of info! Thank you very much!

One minor thing to make things slim, would be to move the Mathjax js code from javascripts/config.js to theme/js/extra.js

@ajstewart
Copy link
Contributor Author

Didn't have time to go through all of it in details. Just read quickly through. Minor comments.

Well done! I think you added plenty of info! Thank you very much!

One minor thing to make things slim, would be to move the Mathjax js code from javascripts/config.js to theme/js/extra.js

Thanks! I have shifted where the Mathjax code lives in d674012.

Copy link
Contributor

@marxide marxide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally done! Mostly typos, language or formatting. Thanks a lot for doing this.

@ajstewart
Copy link
Contributor Author

Finally done! Mostly typos, language or formatting. Thanks a lot for doing this.

Thanks very much for going through that in detail! Especially for filling in the page links that I completely forgot to go back and do.

I've committed all the suggestions.

@ajstewart ajstewart requested a review from marxide March 30, 2021 10:34
- Added missing command sections.
- Changed titles to command names and made order consistent to list.
@ajstewart
Copy link
Contributor Author

@marxide some final edits to adminusage/cli.md in 34104a3. I noticed some commands had no documentation.

I've also been meaning to say if you have any other additions to FAQs to make then feel free, I could only think of the other telescope question that is asked a lot.

- Also added link to translators from the FAQ page.
marxide
marxide previously approved these changes Mar 31, 2021
@ajstewart ajstewart merged commit 6a3d5ad into master Apr 1, 2021
@ajstewart ajstewart deleted the docs-update-adam branch April 1, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants