Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed initial job processing from the UI #466

Merged
merged 4 commits into from
Feb 16, 2021

Conversation

ajstewart
Copy link
Contributor

Added an extra check for coming from UI and the previous status was INI.

Fixes #465.

@ajstewart ajstewart added the bug Something isn't working label Jan 31, 2021
@ajstewart ajstewart requested a review from srggrs January 31, 2021 13:05
@ajstewart ajstewart self-assigned this Jan 31, 2021
@ajstewart
Copy link
Contributor Author

Not sure why tests are failing, when I re-run a different test fails than before.

Tests pass ok on my local environment (3.6.10).

Copy link
Contributor

@srggrs srggrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just one question below before approving

@ajstewart ajstewart requested a review from srggrs February 16, 2021 03:47
@ajstewart
Copy link
Contributor Author

@srggrs I've changed cmd to cli as suggested.

Copy link
Contributor

@srggrs srggrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx!

@ajstewart ajstewart merged commit 66b2dcc into master Feb 16, 2021
@ajstewart ajstewart deleted the issue465-fix-initial-ui-process branch February 16, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial pipeline run from UI broken
2 participants