-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the ability to add images to an existing run #443
Conversation
- Run configuration checks. - Constructing the sources_df ready for new association.
- Outputs need to be checked! - Parallel currently broken.
Ensured measurement pairs are in date (a < b) order
Fixed datetime merging
Fixed running when status is INI
Relations fix, parallel fix and ERR status fix
Fixed monitoring measurement pairs in add image mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajstewart minor things mostly about indentation
@ellawang44 I can see vast_pipeline/tests/test_regression/gen_config.py
but why config files are still present? (e.g. vast_pipeline/tests/pipeline-runs/regression/parallel-deruiter/config.py
)
Changes to template are back compatible. Only the tests give epoch_mode
@srggrs Just finished changing over to generating all the config files on the fly in fd9bb23. The config files under I had to modify the template slightly because sometimes the inputs are dictionaries but the template assumes lists. This change should not affect previously generated config files. |
Co-authored-by: Serg <[email protected]>
Co-authored-by: Serg <[email protected]>
Thanks! I think the test suit should be modified as well... or maybe not? Anyhow the tests fails.... due to missing folders/files. |
The test suite is working on local machines. Something weird is happening with github actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to go, one minor comment on readability of the imports in the regression tests, but not really important.
Thanks for putting this together!
Please use the squash and merge option when merging, as this is a massive PR
Co-authored-by: Serg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds the feature of adding an image to an existing run.
--complete-rerun
when running.config_prev.py
for future jobs.I have tested it on a large scale run by adding epoch 12 to epochs 1 - 11 and it works well.
Also fixes issues #444 and #451 that were found while developing this feature.
Fixes #212.
Fixes #444.
Fixes #451.
@dliptai Fixes #461