preserve source query order on detail view #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srggrs
previously requested changes
Oct 1, 2020
ajstewart
previously approved these changes
Oct 3, 2020
The result source IDs from source queries are stored in the user's session in preserved order. The next and previous source IDs are retrieved from the session (if present) and used for the next / previous links. If no next / previous source is found, no button is displayed. The list of source IDs is saved each time a source query is made with the source list API (`SourceViewSet.list`), before any pagination is performed. Closes #357
marxide
force-pushed
the
store-source-query-order
branch
from
aba8116 to
8e0f87e
Compare
ajstewart
approved these changes
Oct 6, 2020
ajstewart
added a commit
that referenced
this pull request
Oct 8, 2020
Also added missing PR #364 changelog details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result source IDs from source queries are stored in the user's session in preserved order. The next and previous source IDs are retrieved from the session (if present) and used for the next / previous links.
If no next / previous source is found, no button is displayed.
The list of source IDs is saved each time a source query is made with the source list API (
SourceViewSet.list), before any pagination is performed.Closes #357