Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Towards first release #347

Merged
merged 11 commits into from
Sep 27, 2020
Merged

Towards first release #347

merged 11 commits into from
Sep 27, 2020

Conversation

srggrs
Copy link
Contributor

@srggrs srggrs commented Sep 24, 2020 •
edited
Loading

Adding:

  • CHANGELOG file
  • CODE_OF_CONDUCT file
  • renaming DEVELOPING to CONTRIBUTING as per GitHub guidelines
  • fix developing version in package.json
  • added releasing guidelines

@srggrs srggrs requested review from ajstewart and marxide September 24, 2020 11:05
@srggrs srggrs marked this pull request as ready for review September 24, 2020 11:05
marxide
marxide previously approved these changes Sep 25, 2020
View reviewed changes
ajstewart
ajstewart reviewed Sep 25, 2020
View reviewed changes
Copy link
Contributor

@ajstewart ajstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few full stops missing and one other minor change.

@srggrs srggrs requested a review from ajstewart September 25, 2020 04:09
@srggrs srggrs requested a review from marxide September 25, 2020 04:11
@srggrs srggrs merged commit da8c84d into master Sep 27, 2020
@srggrs srggrs deleted the towards-first-release branch September 27, 2020 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajstewart ajstewart ajstewart approved these changes

@marxide marxide Awaiting requested review from marxide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srggrs @ajstewart @marxide