Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website improvements #345

Merged
merged 64 commits into from
Oct 1, 2020
Merged
Show file tree
Hide file tree
Changes from 61 commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
04601d4
Remove 'Analysis' menu option
ajstewart Sep 18, 2020
104759c
Sidebar and job detail celestial
ajstewart Sep 22, 2020
b454c65
Merge branch 'master' into website-improvments
ajstewart Sep 22, 2020
4af4732
Merge branch 'master' into website-improvments
ajstewart Sep 22, 2020
23bb5ae
Improved run detail layout
ajstewart Sep 22, 2020
af7b8be
Added home button and other minor changes
ajstewart Sep 23, 2020
ba3d2e9
Merge branch 'master' into website-improvments
ajstewart Sep 23, 2020
d5cc3ee
Fix left over pipeline urls
ajstewart Sep 23, 2020
a57b4a6
Added tooltips to source query form
ajstewart Sep 23, 2020
3f0d685
Progress commit
ajstewart Sep 23, 2020
fe8a8af
Updated measurement detail page
ajstewart Sep 23, 2020
a208760
Updated measurement detail page
ajstewart Sep 23, 2020
0b06850
Fix measurement detail aladin card size
ajstewart Sep 23, 2020
aa9fe31
Minor changes and fixes
ajstewart Sep 24, 2020
e70708d
Merge branch 'master' into website-improvments
ajstewart Sep 24, 2020
eb1453e
General updates and improvements
ajstewart Sep 24, 2020
c21c004
New line to pipeline.css
ajstewart Sep 24, 2020
bb4d4c8
apply filtering to related source API
marxide Sep 24, 2020
075a806
Add filter to other ViewSets
ajstewart Sep 24, 2020
e284fc7
Merge branch 'master' into website-improvments
ajstewart Sep 25, 2020
54c5fb4
Fixed missing divs causing footer errors
ajstewart Sep 28, 2020
5ad3803
Minor updates from first review comments
ajstewart Sep 28, 2020
4c25401
Renamed measurement_detail sources table object
ajstewart Sep 28, 2020
825055c
Merge branch 'master' into website-improvments
ajstewart Sep 28, 2020
15d085d
Tidied small tags on measurement_detail
ajstewart Sep 28, 2020
68f26c1
Reverted f_meas glob string change
ajstewart Sep 28, 2020
72c4eb6
Typings and minor change
ajstewart Sep 28, 2020
c74ba21
Fix nr_sources syntax
ajstewart Sep 28, 2020
259a481
Fixed typings
ajstewart Sep 28, 2020
f86f232
Changed home path to relative, fixed pipe detail
ajstewart Sep 28, 2020
7bd9413
Added float formatting source galactic coords
ajstewart Sep 28, 2020
a561680
Various fixes
ajstewart Sep 28, 2020
ae020ae
Added float formatting to frequency column
ajstewart Sep 28, 2020
42c1f6e
Fixed external results coordinate
ajstewart Sep 28, 2020
5fbd015
Alternative fix for external query search
ajstewart Sep 28, 2020
2fce576
Added SNR to source meas table
ajstewart Sep 28, 2020
e91fd48
Added local_rms to source meas table
ajstewart Sep 28, 2020
76de688
refactor JS clipboard copy and fix bootstrap tooltip conflict with jq…
marxide Sep 28, 2020
d6d85a6
replace home logo hover image with fa icon
marxide Sep 28, 2020
d7a455c
fix measurement detail layout
marxide Sep 29, 2020
0283d55
remove old clipboard copy script
marxide Sep 29, 2020
1b1cdb1
removed extra whitespace and commented HTML
marxide Sep 29, 2020
9668a12
Update templates/index.html
ajstewart Sep 30, 2020
82d487d
Minor fixes
ajstewart Sep 30, 2020
0a4c9b5
Update templates/index.html
ajstewart Sep 30, 2020
67146d3
Update templates/index.html
ajstewart Sep 30, 2020
d9cde34
Update vast_pipeline/utils/utils.py
ajstewart Sep 30, 2020
fcc9419
Update templates/index.html
ajstewart Sep 30, 2020
1e71795
Update vast_pipeline/utils/utils.py
ajstewart Sep 30, 2020
390b02e
Update vast_pipeline/utils/view.py
ajstewart Sep 30, 2020
d18e09e
Update vast_pipeline/utils/view.py
ajstewart Sep 30, 2020
f9eb7bd
Moved logo back to HTML & increase home logo size
ajstewart Sep 30, 2020
5080c59
Forgotten home font size commit
ajstewart Sep 30, 2020
f0dbfdf
Changed N.A. -> N/A
ajstewart Sep 30, 2020
b50bebc
Added pipeline run to source tables
ajstewart Sep 30, 2020
cc516d3
Make url end / consistent
ajstewart Sep 30, 2020
fdaa7c5
Updated CHANGELOG.md
ajstewart Oct 1, 2020
1db7658
Updated CHANGELOG.md
ajstewart Oct 1, 2020
990b357
Minor CHANGELOG.md update
ajstewart Oct 1, 2020
055035a
Update CHANGELOG.md
ajstewart Oct 1, 2020
4e025f1
Remove comment on CHANGELOG.md
ajstewart Oct 1, 2020
28a9ee7
Update CHANGELOG.md
ajstewart Oct 1, 2020
50e1b2c
Update CHANGELOG.md
ajstewart Oct 1, 2020
eea8a96
Update CHANGELOG.md
ajstewart Oct 1, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 41 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,44 @@
<!--
follow https://github.com/apache/incubator-superset/blob/master/CHANGELOG.md
-->
## Change Log
# Change Log
All notable changes to this project will be documented in this file.

### 0.1.0 (2020/09/27)
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), with an added `List of PRs` section and links to the relevant PRs on the individal updates. This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

#### Added
- Fills out information on all webinterface detail pages [#345](https://github.com/askap-vast/vast-pipeline/pull/345).
- Adds frequency information the measurements and images webinterface tables. [#345](https://github.com/askap-vast/vast-pipeline/pull/345).
- Adds celestial plot and tables to webinterface pipeline detail page [#345](https://github.com/askap-vast/vast-pipeline/pull/345).
- Adds useful links to webinterface navbar [#345](https://github.com/askap-vast/vast-pipeline/pull/345).
- Adds tool tips to webinterface source query [#345](https://github.com/askap-vast/vast-pipeline/pull/345).
- Adds hash reading to webinterface source query to allow filling from URL hash parameters [#345](https://github.com/askap-vast/vast-pipeline/pull/345).
- Add links to number cards on webinterface [#345](https://github.com/askap-vast/vast-pipeline/pull/345).
- Added home icon on hover on webinterface [#345](https://github.com/askap-vast/vast-pipeline/pull/345).
- Added copy-to-clipboard functionality on coordinates on webinterface [#345](https://github.com/askap-vast/vast-pipeline/pull/345).

#### Changed
- Multiple changes to webinterface page layouts [#345](https://github.com/askap-vast/vast-pipeline/pull/345).
- Changes source names to the format `ASKAP_hhmmss.ss(+/-)ddmmss.ss` [#345](https://github.com/askap-vast/vast-pipeline/pull/345).
- Simplified webinterface navbar [#345](https://github.com/askap-vast/vast-pipeline/pull/345).
- Excludes sources and pipeline runs from being listed in the source query page that are not complete on the webinterface [#345](https://github.com/askap-vast/vast-pipeline/pull/345).
- Clarifies number of measurements on webinterface detail pages [#345](https://github.com/askap-vast/vast-pipeline/pull/345).
- Changed `N.A.` labels to `N/A` on the webinterface [#345](https://github.com/askap-vast/vast-pipeline/pull/345).

#### Fixed
- Fixes webinterface navbar overspill at small sizes [#345](https://github.com/askap-vast/vast-pipeline/pull/345).
- Fixes webinterface favourite source table [#345](https://github.com/askap-vast/vast-pipeline/pull/345).

#### Removed
- Removed `static/css/collapse-box.css`, content moved to `pipeline.css` [#345](https://github.com/askap-vast/vast-pipeline/pull/345).

#### List of PRs
- [#345](https://github.com/askap-vast/vast-pipeline/pull/345) feat, fix: Website improvements.

## [0.1.0] (2020/09/27)

First release of the Vast Pipeline. This was able to process 707 images (EPOCH01 to EPOCH11x) on a machine with 64 GB of RAM.

#### List of PRs
- [#347](https://github.com/askap-vast/vast-pipeline/pull/347) feat: Towards first release
- [#354](https://github.com/askap-vast/vast-pipeline/pull/354) fix, model: Updated Band model fields to floats
- [#346](https://github.com/askap-vast/vast-pipeline/pull/346) fix: fix JS9 overflow in measurement detail view
Expand Down Expand Up @@ -39,5 +71,8 @@ First release of the Vast Pipeline. This was able to process 707 images (EPOCH01
- [#291](https://github.com/askap-vast/vast-pipeline/pull/291) fix: Bug fix for forced_photom cluster allow_nan
- [#289](https://github.com/askap-vast/vast-pipeline/pull/289) fix: Fix broken UI run creation
- [#287](https://github.com/askap-vast/vast-pipeline/pull/287) fix: Fix forced measurement parquet files write
- [#286](https://github.com/askap-vast/vast-pipeline/pull/285) fix: compile JS9 without helper option
- [#286](https://github.com/askap-vast/vast-pipeline/pull/286) fix: compile JS9 without helper option
- [#285](https://github.com/askap-vast/vast-pipeline/pull/285) fix: Fix removing forced parquet and clear images from piperun

[unreleased]: https://github.com/askap-vast/vast-pipeline/compare/0.1.0...HEAD
[0.1.0]: https://github.com/askap-vast/vast-pipeline/releases/0.1.0
6 changes: 0 additions & 6 deletions static/css/collapse-box.css

This file was deleted.

26 changes: 26 additions & 0 deletions static/css/pipeline.css
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,29 @@
#feedbackModalDialog {
max-width: 75%;
}

#homeLogo:hover img{
display: none;
}

#homeLogo:hover:before {
font-style: normal;
font-variant: normal;
font-size: 1.5em;
text-rendering: auto;
-webkit-font-smoothing: antialiased;
font-family: "Font Awesome 5 Free";
font-weight: 900;
content: '\f015';
}

.dl-small dd {
margin-bottom: 0rem;
}

.card-header .fa {
transition: .3s transform ease-in-out;
}
.card-header .collapsed .fa {
transform: rotate(-90deg);
}
5 changes: 3 additions & 2 deletions static/css/sb-admin-2.css
Original file line number Diff line number Diff line change
Expand Up @@ -10081,7 +10081,8 @@ a:focus {
}

.sidebar {
width: 4.5rem;
text-align: center;
width: 6.5rem;
min-height: 100vh;
}

Expand Down Expand Up @@ -10236,7 +10237,7 @@ a:focus {
font-size: 0.65rem;
}

@media (min-width: 768px) {
@media (min-width: 3840px) {
.sidebar {
width: 13rem !important;
}
Expand Down
Binary file added static/img/home-solid.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 16 additions & 0 deletions static/js/clipboard-copy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
$(function() {
// append copy icon to each .clipboard-copy element
$('.clipboard-copy').append('<i class="far fa-copy ml-2" data-toggle="tooltip" data-placement="top"></i>');
// init the tooltip for the copy icons
$('i.fa-copy[data-toggle="tooltip"]').tooltip({title: "Copy to clipboard"});
// perform the copy action and update tooltip title to notify user
$('.clipboard-copy > i.fa-copy').on("click", function() {
let data = $(this).parent().text();
navigator.clipboard.writeText(data);
$(this).tooltip('dispose').tooltip({"title": "Copied!"}).tooltip('update').tooltip('show');
})
// revert copy tooltip title to original on mouseout
$('.clipboard-copy > i.fa-copy').on("mouseout", function() {
$(this).tooltip('dispose').tooltip({title: "Copy to clipboard"});
})
});
51 changes: 37 additions & 14 deletions static/js/datatables-pipeline.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ function obj_formatter(obj) {
// Call the dataTables jQuery plugin
$(document).ready(function() {

$('[data-toggle="tooltip"]').tooltip();
let dataConfParsed = JSON.parse(document.getElementById('datatable-conf').textContent);
let dataConfList = (Array.isArray(dataConfParsed)) ? dataConfParsed : [dataConfParsed];
for (let dataConf of dataConfList){
Expand All @@ -66,6 +67,7 @@ $(document).ready(function() {
ajax: dataConf.api,
columns: dataConf.colsFields,
order: dataConf.order,
searchDelay: 2000,
};
} else {
// expect that there is a 'data' attribute with the data
Expand Down Expand Up @@ -112,67 +114,88 @@ $(document).ready(function() {
"targets": 3,
"data": "image",
"render": function ( data, type, row, meta ) {
return '<a href="' + img_url + row[14] + '"target="_blank">' + row[3] + '</a>';
return '<a href="' + img_url + row[17] + '"target="_blank">' + row[3] + '</a>';
}
},
{
"targets": 4,
"data": "ra",
"data": "frequency",
"render": function ( data, type, row, meta ) {
return row[4].toFixed(4);
return row[4].toFixed(2);
}
},
{
"targets": 5,
"data": "ra_err",
"data": "ra",
"render": function ( data, type, row, meta ) {
return (row[5] * 3600.).toFixed(4);
return row[5].toFixed(4);
}
},
{
"targets": 6,
"data": "dec",
"data": "ra_err",
"render": function ( data, type, row, meta ) {
return row[6].toFixed(4);
return (row[6] * 3600.).toFixed(4);
}
},
{
"targets": 7,
"data": "dec_err",
"data": "dec",
"render": function ( data, type, row, meta ) {
return (row[7] * 3600.).toFixed(4);
return row[7].toFixed(4);
}
},
{
"targets": 8,
"data": "flux_int",
"data": "dec_err",
"render": function ( data, type, row, meta ) {
return (row[8]).toFixed(3);
return (row[8] * 3600.).toFixed(4);
}
},
{
"targets": 9,
"data": "flux_int_err",
"data": "flux_int",
"render": function ( data, type, row, meta ) {
return (row[9]).toFixed(3);
}
},
{
"targets": 10,
"data": "flux_peak",
"data": "flux_int_err",
"render": function ( data, type, row, meta ) {
return (row[10]).toFixed(3);
}
},
{
"targets": 11,
"data": "flux_peak_err",
"data": "flux_peak",
"render": function ( data, type, row, meta ) {
return (row[11]).toFixed(3);
}
},
{
"targets": 12,
"data": "flux_peak_err",
"render": function ( data, type, row, meta ) {
return (row[12]).toFixed(3);
}
},
{
"targets": 13,
"data": "local_rms",
"render": function ( data, type, row, meta ) {
return (row[13]).toFixed(2);
}
},
{
"targets": 14,
"data": "snr",
"render": function ( data, type, row, meta ) {
return (row[14]).toFixed(2);
}
},
{
"targets": 17,
"searchable": false,
"visible": false
}
Expand Down
76 changes: 33 additions & 43 deletions templates/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@
<!-- Custom styles on top of the SB admin template-->
<link href="{% static 'css/pipeline.min.css' %}" rel="stylesheet">

<!-- Custom styles on top of the SB admin template-->
<link href="{% static 'css/pipeline.min.css' %}" rel="stylesheet">

{% block head %}

{% endblock head %}
Expand All @@ -42,9 +39,8 @@
<ul class="navbar-nav bg-gradient-primary sidebar sidebar-dark accordion" id="accordionSidebar">

<!-- Sidebar - Brand -->
<a class="sidebar-brand d-flex align-items-center justify-content-center" href="{% url 'index' %}">
<img src="{% static 'img/vast.png' %}" width="50%">
<!-- <div class="sidebar-brand-text mx-1">VAST Pipeline</div> -->
<a class="sidebar-brand d-flex align-items-center justify-content-center" href="{% url 'index' %}" id='homeLogo'>
<img src="{% static 'img/vast.png' %}" width="50%" >
</a>

<!-- Divider -->
Expand All @@ -67,65 +63,61 @@

<!-- Nav Item - Pipeline Runs -->
<li class="nav-item">
<a class="nav-link collapsed" href="#" data-toggle="collapse" data-target="#collapsePipeRun" aria-expanded="true" aria-controls="collapsePipeRun">
<a class="nav-link collapsed" href="{% url 'vast_pipeline:run_index' %}">
<i class="fas fa-fw fa-table"></i>
<span>Pipeline Runs</span>
</a>
<div id="collapsePipeRun" class="collapse" aria-labelledby="headingDataset" data-parent="#accordionSidebar">
<div class="bg-white py-2 collapse-inner rounded">
<a class="collapse-item" href="{% url 'vast_pipeline:run_index' %}">Overview</a>
</div>
</div>
</li>

<!-- Nav Item - Sources -->
<li class="nav-item">
<a class="nav-link collapsed" href="#" data-toggle="collapse" data-target="#collapseSource" aria-expanded="true" aria-controls="collapseSource">
<li class="nav-item" id="sourcesLink">
<a class="nav-link collapsed" href="{% url 'vast_pipeline:source_query' %}">
<i class="fas fa-fw fa-share-alt"></i>
<span>Sources</span>
<span>Sources Query</span>
</a>
<div id="collapseSource" class="collapse" aria-labelledby="headingCatalog" data-parent="#accordionSidebar">
<div class="bg-white py-2 collapse-inner rounded">
<a class="collapse-item" href="{% url 'vast_pipeline:source_query' %}">View all sources</a>
</div>
</div>
</li>

<!-- Nav Item - Measurements -->
<li class="nav-item">
<a class="nav-link collapsed" href="#" data-toggle="collapse" data-target="#collapseSourceMeas" aria-expanded="true" aria-controls="collapseSourceMeas">
<a class="nav-link collapsed" href="{% url 'vast_pipeline:measurement_index' %}">
<i class="fas fa-fw fa-bolt"></i>
<span>Measurements</span>
</a>
<div id="collapseSourceMeas" class="collapse" aria-labelledby="headingSource" data-parent="#accordionSidebar">
<div class="bg-white py-2 collapse-inner rounded">
<a class="collapse-item" href="{% url 'vast_pipeline:measurement_index' %}">View all measurements</a>
</div>
</div>
</li>

<!-- Nav Item - Images -->
<li class="nav-item">
<a class="nav-link collapsed" href="#" data-toggle="collapse" data-target="#collapseImage" aria-expanded="true" aria-controls="collapseImage">
<a class="nav-link collapsed" href="{% url 'vast_pipeline:image_index' %}">
<i class="fas fa-fw fa-images"></i>
<span>Images</span>
</a>
<div id="collapseImage" class="collapse" aria-labelledby="headingImage" data-parent="#accordionSidebar">
<div class="bg-white py-2 collapse-inner rounded">
<a class="collapse-item" href="{% url 'vast_pipeline:image_index' %}">View all images</a>
</div>
</div>
</li>

<!-- Nav Item - Analysis -->

<li class="nav-item">
<a class="nav-link collapsed" href="#" data-toggle="collapse" data-target="#collapseAnalysis" aria-expanded="true" aria-controls="collapseAnalysis">
<i class="fas fa-fw fa-fingerprint"></i>
<span>Analysis</span>
<a class="nav-link collapsed" target="_blank" href="https://github.com/askap-vast/vast-pipeline/issues/new">
<i class="fab fa-fw fa-github"></i>
<span>Pipeline Repository</span>
</a>
<div id="collapseAnalysis" class="collapse" aria-labelledby="headingAnalysis" data-parent="#accordionSidebar">
</li>

<li class="nav-item">
<a class="nav-link collapsed" target="_blank" href="https://github.com/askap-vast/vast-pipeline/issues/new">
<i class="fas fa-fw fa-exclamation"></i>
<span>Raise Issue</span>
</a>
</li>

<li class="nav-item">
<a class="nav-link collapsed" href="#" data-toggle="collapse" data-target="#collapseLinks" aria-expanded="true" aria-controls="collapseLinks">
<i class="fas fa-fw fa-link"></i>
<span>VAST Links</span>
</a>
<div id="collapseLinks" class="collapse" aria-labelledby="headingDataset" data-parent="#accordionSidebar">
<div class="bg-white py-2 collapse-inner rounded">
<a class="collapse-item" href="">Overview</a>
<a class="collapse-item" target="_blank" href="https://github.com/askap-vast">GitHub</a>
<a class="collapse-item" target="_blank" href="https://data.vast-survey.org">JupyterHub</a>
<a class="collapse-item" target="_blank" href="https://vast-survey.org">Website</a>
<a class="collapse-item" target="_blank" href="https://github.com/askap-vast/vast-project/wiki">Wiki</a>
</div>
</div>
</li>
Expand Down Expand Up @@ -266,9 +258,9 @@
</a>

{% block modal %}

{% endblock modal %}

{% block scripts %}
<!-- Bootstrap core JavaScript-->
<script src="{% static 'vendor/jquery/jquery.min.js' %}"></script>
<script src="{% static 'vendor/bootstrap/js/bootstrap.bundle.min.js' %}"></script>
Expand All @@ -281,11 +273,9 @@

<!-- Alerts script for all pages-->
<script src="{% static 'js/alerts.min.js' %}"></script>
{% endblock scripts %}

{% block custom_page_scripts %}

{% endblock custom_page_scripts %}

</body>

</html>
Loading