Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better migration management explanation #334

Merged
merged 3 commits into from
Sep 14, 2020
Merged

better migration management explanation #334

merged 3 commits into from
Sep 14, 2020

Conversation

srggrs
Copy link
Contributor

@srggrs srggrs commented Sep 11, 2020

Fix #304

@srggrs srggrs requested review from ajstewart and marxide September 11, 2020 07:47
marxide
marxide requested changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@marxide marxide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@srggrs @marxide
Update DEVELOPING.md
4ebfca6 
Co-authored-by: Andrew O'Brien <[email protected]>
@srggrs srggrs requested a review from marxide September 13, 2020 23:52
ajstewart
ajstewart reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@ajstewart ajstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the comment on the wording at the beginning otherwise the rest is clear to me!

@srggrs srggrs requested a review from ajstewart September 14, 2020 02:30
@srggrs srggrs merged commit f8c1c7a into master Sep 14, 2020
@srggrs srggrs deleted the issue-304-migration-dev-docs branch September 14, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajstewart ajstewart ajstewart approved these changes

@marxide marxide marxide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration strategy broken?
3 participants
@srggrs @ajstewart @marxide