Fix write config feedback and validation #303
Conversation
What is meant by this bit? |
I tried to implement it but is a bit buggy to use with the toggle on/off and when you type, the line numbers are completely messed up |
Is this still better than what we already have? At the moment we don't have feedback right, but does everything else work ok (I think I remember Daniele pointing out an issue)? I'm just trying to gain what this PR achieves apart from the feedback - and whether gaining the feedback is at the detriment of the functionality. |
this PR leave the functionality as it was, just add feedback on the config writing and fix a small bug on the new sources nr displayed on the run detail page. Daniele issue was that it did write a wrong config as he missed a bracket, but the Python syntax error was not very helpful in point that out, though by looking at it I can immediately see that a bracket was missing (see pic below: missing closing bracket on SELAVY list). In conclusion this does not remove functionality at all. |
|
Ah ok so the PrismJS Live is being closed as you couldn't get it working correctly and is not implemented? |
yes, and it should eventually be given another try in the future |
Fix #273 feedback on writing pipeline run config to file and small bug. Implementation of PrismJS seems not working great (at least I didn't managed to make that works nice) close #292