Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No check for name collision before issuing fincontract with -s option #4

Open
s-tikhomirov opened this issue May 31, 2017 · 0 comments

Comments

@s-tikhomirov
Copy link
Collaborator

Consider the following:

create-fincontract -i 0x0 -s one One(USD)
create-fincontract -i 0x0 -s one One(EUR)

Observed output of the second command:

sender info One transaction was sent. HASH: 0x8c6517452e
desc-deploy info One primitive stored with ID: 0x0cf1b7b5e0
sender info createFincontract transaction was sent. HASH: 0x76f9acfbbb
deploy info Fincontract: 0x3b4011777f
deploy info Created for: 0xebd0a594e3
sender info issueFor transaction was sent. HASH: 0x5a2c2d01a6
deploy info Fincontract: 0x3b4011777f
deploy info Issued for:  0x0000000000
ℹ ID added to autocomplete!
⚠ Fincontract with this name already exists!

That is, One(EUR) is issued, but not saved.

Possibly better outcome:

⚠ Fincontract with this name already exists!

(One(EUR) is not issued until the user removes -s option or changes the name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant