Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use viewer for all PDFs #152

Open
banesullivan opened this issue Apr 24, 2018 · 6 comments
Open

Use viewer for all PDFs #152

banesullivan opened this issue Apr 24, 2018 · 6 comments

Comments

@banesullivan
Copy link

Would it be possible to set the viewer that is shipped in this package as the default viewer for all PDFs in Atom?

The viewer you all have made here is far better than any other PDF viewers for Atom that I have seen! I would love to be able to open all PDFs in Atom using the viewer in this package rather than other packages.

@ashthespy
Copy link
Owner

Hi,
This is currently not possible, but might it might be possible to add a 'Open with..' kind of command. Let me explore a bit, but no promises on a timeline.

@Aerijo
Copy link

Aerijo commented Aug 27, 2019

@ashthespy You can register the package as a URI handler, like this

@ashthespy
Copy link
Owner

@Aerijo Thanks for the tip,
I started working on pulling the pdf viewer from this package out into it's own package, but didn't get down to publishing it. Do you have an idea/roadmap of what your planning with your atom-pdf-view-plus package?

@Aerijo
Copy link

Aerijo commented Aug 27, 2019

Definitely want to add synctex support, like pdf-view has. I'll probably model the viewer side of things on this package and Latex-Workshop. Also things like remembering zoom, position, tool state, etc., when the PDF is refreshed.

Beyond that, finding ways to insert theme styles, instead of hard coding them.

@ashthespy
Copy link
Owner

Cool, will keep an eye out!

@Aerijo
Copy link

Aerijo commented Sep 14, 2019

@ashthespy It's almost done. Position is remembered, and the user theme is somewhat used (the body is transparent, so it kind of just shows through).

Instead of built in synctex, I've opted to go with a generic interaction service pdfview. Packages can subscribe to click, doubleclick, (and eventually more) events from individual PDFs. The position of the click is given in PDF points, to keep it generic. The consumers can also tell the PDF to scroll to a certain position. This makes it easy to implement a small synctex service, while keeping the package itself language agnostic. Though I'll probably add it as a configurable option anyway.

My goal with the service is to make it good enough to replace the built in viewer here. I plan to add more context about the clicks (which buttons, is ctrl held, etc.), and scroll + pagechange + keypress subscriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants