-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--strict mode not working, even with via additional_swiftlint_args
#151
Comments
--strict
doesn't do workadditional_swiftlint_args
I see, thanks for opening the issue. Can you show how you're invoking this in the |
I have the same problem. I wrote like the following in Dangerfile:
|
Has anyone found a (maybe temporary) solution of the problem in the meantime? |
I have same issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just wanted to setup swiftlint via danger using this gem, but when I specify the
additional_swiftlint_args: '--strict'
as implemented in #59, nothing actually changes, still all warnings show up as warnings and danger doesn't fail, although I have setup bothfail_on_error: true
on this gem and even--fail-on-errors=true
on danger itself. Even settingmax_num_violations
to0
doesn't fail if there's only a warning. So basically there seems to be no way to make the CI fail on warnings as of now. 😞Note that the
--strict
parameter does not convert warnings to errors, instead it just ensures the overallswiftlint
command fails by returning with a non zero status code (see this comment). That's probably why--strict
is doing nothing ...The text was updated successfully, but these errors were encountered: