Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verbose argument to IOHandler and switch from print to logging #11

Closed
asgersvenning opened this issue Oct 23, 2024 · 1 comment
Closed

Add verbose argument to IOHandler and switch from print to logging #11

asgersvenning opened this issue Oct 23, 2024 · 1 comment
Assignees
@GuillaumeMougeot @asgersvenning
Labels
enhancement New feature or request

Comments

@asgersvenning
Copy link
Owner

IOHandler in pryemotedata.implicit_mount should have a verbose keyword argument and all print statements should use the logging library
@asgersvenning asgersvenning added the enhancement New feature or request label Oct 23, 2024
@GuillaumeMougeot GuillaumeMougeot linked a pull request Oct 28, 2024 that will close this issue
add 'verbose' in IOHandler #12
Merged
@GuillaumeMougeot GuillaumeMougeot removed a link to a pull request Oct 28, 2024
add 'verbose' in IOHandler #12
Merged
@GuillaumeMougeot GuillaumeMougeot mentioned this issue Oct 28, 2024
Merged
@asgersvenning
Copy link
Owner Author

Fixed with #12 and 4a34544, 4e6d92e and 98416f0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeMougeot GuillaumeMougeot

@asgersvenning asgersvenning

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuillaumeMougeot @asgersvenning