Add test to assure generateTagSlug() works like str_slug()

AsgardCms · Feb 27, 2018 · 8e8bc6d · 8e8bc6d
1 parent b809722
commit 8e8bc6d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/Modules/Tag/Tests/Integration/TaggableTraitTest.php b/Modules/Tag/Tests/Integration/TaggableTraitTest.php
@@ -3,6 +3,7 @@
 namespace Modules\Tag\Tests\Integration;
 
 use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Str;
 use Modules\Page\Entities\Page;
 use Modules\Page\Repositories\PageRepository;
 use Modules\Tag\Repositories\TagRepository;
@@ -132,6 +133,18 @@ public function it_gets_all_tags_for_a_namespace()
         $this->assertCount(3, Page::allTags()->get());
     }
 
+    /** @test */
+    public function it_generates_slug_like_original_str_slug()
+    {
+        $page = $this->createPage();
+
+        $this->assertEquals(Str::slug('hello world'), $page->generateTagSlug('hello world'));
+        $this->assertEquals(Str::slug('hello world'), $page->generateTagSlug('hello-world'));
+        $this->assertEquals(Str::slug('hello_world'), $page->generateTagSlug('hello_world'));
+        $this->assertEquals(Str::slug('hello_world', '_'), $page->generateTagSlug('hello_world', '_'));
+        $this->assertEquals(Str::slug('user@host'), $page->generateTagSlug('user@host'));
+    }
+
     /** @test */
     public function it_gets_pages_with_non_latin_tags()
     {

diff --git a/Modules/Tag/Traits/TaggableTrait.php b/Modules/Tag/Traits/TaggableTrait.php
@@ -204,7 +204,7 @@ protected function getEntityClassName()
     /**
      * {@inheritdoc}
      */
-    protected function generateTagSlug($name, $separator = '-')
+    public function generateTagSlug($name, $separator = '-')
     {
         // Convert all dashes/underscores into separator
         $flip = $separator == '-' ? '_' : '-';