Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating section link in repository README is incorrect #1823

Closed
oddhack opened this issue Nov 16, 2020 · 1 comment
Closed

Floating section link in repository README is incorrect #1823

oddhack opened this issue Nov 16, 2020 · 1 comment
Assignees
Milestone

Comments

@oddhack
Copy link
Contributor

oddhack commented Nov 16, 2020

https://github.com/asciidoctor/asciidoctor-pdf#optimizing-the-generated-pdf should land on the "Optimizing the Generated PDF" section but doesn't as the floating link (selected by the paragraph icon to the left of the section title) has this anchor, but the generated ID in the HTML prefixes the actual HTML anchor to be 'user-content-optimizing-the-generated-pdf'. This is true of other section anchors as well. Maybe this is something weird about Github's asciidoctor viewer?

@mojavelinux
Copy link
Member

mojavelinux commented Nov 16, 2020

The addition of user-content- prefix is the standard behavior of GitHub (to avoid ID conflicts). There is a script that maps the fragment in the URL to this prefixed ID, thus making it transparent. You can find an explanation of how it works in this issue and other linked references github/markup#425

From time to time, GitHub rolls out or A-B tests changes to the UI. These changes sometimes break behavior. It's likely that in a few days, you will no longer see this problem. If it persists, then it needs to be filed in the issue tracker I referenced above.

@mojavelinux mojavelinux self-assigned this Nov 16, 2020
@mojavelinux mojavelinux added this to the support milestone Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants