Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing query_params on Put/Post/Patch requests. Update tox tests to include django 2.2.6 and drf 3.10.3 versions #142

Open
lingster opened this issue Oct 22, 2019 · 5 comments

Comments

@lingster
Copy link
Contributor

Hi, I'd like to submit a PR to update this package.
Also would you like some help to push a new version to pypi?

@avelis
Copy link
Collaborator

avelis commented Oct 22, 2019

@lingster I can do my best. I haven't pushed a release in a while but can look into it.

@lingster
Copy link
Contributor Author

lingster commented Oct 23, 2019

@avelis thanks for replying, created the following PR: #143. Unit tests are passing. Pushing a release should also resolve #134

@lingster
Copy link
Contributor Author

@avelis I've also included in the PR fix and tests for an issue where the query params are not stored for PUT/POST/PATCH requests. could you kindly include this for the release?

@avelis
Copy link
Collaborator

avelis commented Oct 23, 2019

@lingster Can you look into why there is one failing test. Looks to be only on one configuration. If it's benign I can merge it in.
https://travis-ci.org/aschn/drf-tracking/jobs/601860781?utm_medium=notification&utm_source=github_status

@lingster
Copy link
Contributor Author

@avelis that should be fixed. I don't have multiple python versions on my system so i am relying on the CI to confirm everything is working.

@lingster lingster changed the title Update tox tests to include django 2.2.6 and drf 3.10.3 versions Fix missing query_params on Put/Post/Patch requests. Update tox tests to include django 2.2.6 and drf 3.10.3 versions Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants