Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reword): support invoking editors with spaces in name #722

Merged
merged 1 commit into from
Jan 12, 2023
Merged

fix(reword): support invoking editors with spaces in name #722

merged 1 commit into from
Jan 12, 2023

Conversation

arxanas
Copy link
Owner

@arxanas arxanas commented Dec 31, 2022

Closes #718.

@arxanas arxanas mentioned this pull request Dec 31, 2022
Closed
@arxanas
Copy link
Owner Author

arxanas commented Jan 11, 2023

Unfortunately, this breaks the Nix build, and I have no idea how to fix it. The dialoguer package might also take a while to release a new version, too, and considering the amount of customization/fixes we've had to do, it might be better to just vendor the source code at this point.

@arxanas arxanas force-pushed the arxanas/reword branch 2 times, most recently from 037a800 to bc24b12 Compare January 11, 2023 23:31
@arxanas arxanas enabled auto-merge (rebase) January 11, 2023 23:33
@arxanas
fix(reword): support invoking editors with spaces in name
9af357c 
This is particularly likely to happen on Windows, where the editor path may include the `C:\Program Files` directory.
@arxanas arxanas merged commit c889b7a into master Jan 12, 2023
@arxanas arxanas deleted the arxanas/reword branch January 12, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reword on Windows isn't able to use editors with quoted file paths
1 participant
@arxanas