Garbage collection reachability improvements #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detected by IntelliJ but not by `cargo clippy`.
The fact that this function returns an unsorted `Vec` is relevant to call out, since in many cases, we will want to sort the `Vec` for determinism (e.g. before outputting elements of the `Vec` in a test).
arxanas
added a commit
that referenced
this pull request
Jun 28, 2022
Unfortunately, adding garbage collection references for every invisible head is a significant performant regression. To fix this, we instead only mark commits as reachable if they're *active* (would appear in the smartlog). This does mean that commits which were available in the DAG but not used by the smartlog might get garbage collected, but it seems like an acceptable trade-off.
arxanas
added a commit
that referenced
this pull request
Jun 28, 2022
Unfortunately, adding garbage collection references for every invisible head is a significant performant regression. To fix this, we instead only mark commits as reachable if they're *active* (would appear in the smartlog). This does mean that commits which were available in the DAG but not used by the smartlog might get garbage collected, but it seems like an acceptable trade-off.
arxanas
added a commit
that referenced
this pull request
Jun 28, 2022
Unfortunately, adding garbage collection references for every invisible head is a significant performant regression. To fix this, we instead only mark commits as reachable if they're *active* (would appear in the smartlog). This does mean that commits which were available in the DAG but not used by the smartlog might get garbage collected, but it seems like an acceptable trade-off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #412. With this stack, any commit which appears in
git smartlogshould be marked as reachable for GC, regardless of where it came from.