Allow passing a callback_url param

[bzf]

When building an application we need to do two types of Twitter
authentication - one for signing in to our application (and creating a
User) and another for associating Twitter accounts to their User
account.

By passing a custom callback_url param we can have one controller
method for signing in and another one for the associating part and just
have the application set the callback when starting the authentication
process.

[bzf]

There seems to be some install errors on CI. It's also dipping under the 94% coverage limit due to not adding a test - should I add one?

Also, when the request comes back from Twitter the request.env["omniauth.auth"] (and lands in a method that's not the default def callback one) value is nil - do you know anything about what might've caused that and if that is expected?

[raysrashmi]

Thanks for the PR.
Reason behind getting request.env["omniauth.auth"] as nil is because it is not going in to callback_phase method where we assign auth_hash to env['omniauth.auth'] see here. So basically we need to set options[:callback] same as callback_url or either override callaback_path method

[bzf]

@raysrashmi Alright, I've tried overriding the callback_path method and I did not get it to work. I've looked through the links you sent but could not understand how everything fits together. Would you have time to pair on this sometime, or help me by pointing me into the right direction? 😃

EDIT: I got it working now, but I'm not sure if accessing the session variable is a good idea. Also it needs some tests, so I'll add some!

[raysrashmi]

@bzf I think its fine to use session and I don't think there is any other way to get callback_url. 👍 for tests.

[raysrashmi]

@bzf Any update on this?

[bzf]

@raysrashmi Sorry that I haven't responded! I'll try to write up a test today!

[bzf]

Added a spec in the latest commit

[raysrashmi]

@bzf Thank you for the specs. I found on issue in callback_url when there is no params['callback_url'] it just redirect for Pin based login so we need to call parent't class callback_url. I have pushed a commit 91485a4 have a look and if you find it good cherry-pick in your branch 😊

[bzf]

@raysrashmi Cherry picked! 👍

[raysrashmi]

@bzf Released a new version 1.4.0 😊 . Thank you so much for the PR ❤️

[bzf]

@raysrashmi Thanks for merging it! 😄 ❤️

[chriso0710]

also see #103