Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tracking to Alert list actions #14813

Merged

Conversation

olerichter00
Copy link
Contributor

@olerichter00 olerichter00 commented Nov 7, 2024

Addresses ONYX-894

Related Cohesion PR: artsy/cohesion#540

Description

This PR adds tracking to Alert list actions ("View Artworks" & "Edit").

Bildschirmfoto 2024-11-28 um 15 56 25

@olerichter00 olerichter00 marked this pull request as draft November 7, 2024 13:37
@olerichter00 olerichter00 self-assigned this Nov 7, 2024
Copy link

relativeci bot commented Nov 7, 2024

#1087 Bundle Size — 9.57MiB (+0.25%).

5f74312(current) vs ffe4f84 main#484(baseline)

Important

Bundle introduced 1 and removed 4 duplicate packages – View changed duplicate packages

Warning

Bundle introduced 3 new packages: web-vitals, @sentry-internal/browser-utils, stylis – View changed packages

Bundle metrics  Change 8 changes Regression 1 regression Improvement 3 improvements
                 Current
#1087
     Baseline
#484
Improvement  Initial JS 3.72MiB(-5.89%) 3.95MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 90.84% 2.04%
No change  Chunks 143 143
Change  Assets 147(+0.68%) 146
Change  Modules 5707(+1.24%) 5637
Regression  Duplicate Modules 496(+9.01%) 455
Change  Duplicate Code 5.85%(-0.51%) 5.88%
Improvement  Packages 282(-3.09%) 291
Improvement  Duplicate Packages 39(-7.14%) 42
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#1087
     Baseline
#484
Regression  JS 9.36MiB (+0.49%) 9.31MiB
Improvement  Other 214.99KiB (-9.61%) 237.84KiB

Bundle analysis reportBranch olerichter00/ONYX-894/add-tracki...Project dashboard


Generated by RelativeCIDocumentationReport issue

@olerichter00 olerichter00 force-pushed the olerichter00/ONYX-894/add-tracking-to-alert-list-actions branch from 63b70f9 to 5f74312 Compare November 28, 2024 14:55
@olerichter00 olerichter00 marked this pull request as ready for review November 28, 2024 14:55
@olerichter00 olerichter00 merged commit 914d93c into main Nov 29, 2024
11 checks passed
@olerichter00 olerichter00 deleted the olerichter00/ONYX-894/add-tracking-to-alert-list-actions branch November 29, 2024 08:39
@artsy-peril artsy-peril bot mentioned this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant