Use Danger to append a checklist to the end of a PR

[orta]

We'd like to improve visibility of whether someone has tested on a device, or run through the code at all. So, to look at improving this, we're going to try two things:

• Making a checklist inside the PR body from Danger on every PR for both the PR author, and all assignees to verify they've double checked - code then app.

• Making it easier to get set up with the code locally. Danger can provide a C&Pable way to get the PR running locally or on a device if we get PRs deployable via Emission.

This issue will have what I'd imagine the template to look like appended. See below:

---

Tested on Device?

• @orta
• @mennenia

How to get set up with this PR?

 

To run on your computer: Ensure you have hub installed:

git checkout https://github.com/artsy/emission/pull/541
yarn install
cd example; pod install; cd ..
yarn ios
yarn start

To run inside Eigen (prod or beta) or Emission (beta): Shake the phone to get the Admin menu.

If you see "Use Staging React Env" - click that and restart, then follow the next step.

Click on "Choose an RN build" - then pick the one that says: "X,Y,Z"

[mennenia]

LOVE THIS

does the apphub stuff also do prs? or just what is in master for emission?

[orta]

Today: only master - it's not unreasonable to do PRs too.

[alloy]

Looking great! Just missing the cd Example && pod install && cd .. part

[orta]

Added 👍 (works with Fish then too)

[alloy]

I’m actually thinking that maybe we shouldn’t make this dependent on having hub installed, if we’re offering copy-pasteable commands anyways?

[orta]

could use the git fetch origin pull/ID/head:BRANCHNAME feature - the PR one is only useful for cross-fork PRs

[orta]

Fixed by #558