Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Members of 'final' classes are implicitly 'final'; use 'public' instead of 'open' #33

Open
ykws opened this issue Oct 14, 2018 · 1 comment · Fixed by ykws/AKImageCropperView#6 · May be fixed by #34
Open

Members of 'final' classes are implicitly 'final'; use 'public' instead of 'open' #33

ykws opened this issue Oct 14, 2018 · 1 comment · Fixed by ykws/AKImageCropperView#6 · May be fixed by #34

Comments

@ykws
Copy link

ykws commented Oct 14, 2018

3 issues.

  • AKImageCropperScrollView.swift:18:14: Members of 'final' classes are implicitly 'final'; use 'public' instead of 'open'
  • AKImageCropperScrollView.swift:28:14: Members of 'final' classes are implicitly 'final'; use 'public' instead of 'open'
  • AKImageCropperScrollView.swift:44:14: Members of 'final' classes are implicitly 'final'; use 'public' instead of 'open'
ykws added a commit to ykws/AKImageCropperView that referenced this issue Oct 15, 2018
@ykws
Use public
ffec0b9 
Members of 'final' classes are implicitly 'final'; use 'public' instead of 'open'

fixes artemkrachulov#33
@ykws ykws mentioned this issue Oct 15, 2018
Merged
@ykws ykws linked a pull request Oct 15, 2018 that will close this issue
Open
@ykws
Copy link
Author

ykws commented Oct 15, 2018

This issue was unintentionally closed when on my forked repository pull request and merged, so reopen.

@ykws ykws reopened this Oct 15, 2018
@ykws ykws mentioned this issue Oct 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use public ykws/AKImageCropperView
Use public ykws/AKImageCropperView
1 participant
@ykws