Remove SIP path from SIP metadata validation #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 53.48% 60.20% +6.71%
==========================================
Files 29 29
Lines 2023 1985 -38
==========================================
+ Hits 1082 1195 +113
+ Misses 869 696 -173
- Partials 72 94 +22 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
djjuhasz
requested changes
Nov 20, 2024
jraddaoui
reviewed
Nov 20, 2024
internal/workflow/preprocessing.go
Outdated
| result.validationError(ctx, ev, "metadata validation has failed", validateMetadata.Failures) | ||
| escapedFailures := make([]string, len(validateMetadata.Failures)) | ||
| for _, f := range validateMetadata.Failures { | ||
| escapedFailures = append(escapedFailures, strings.ReplaceAll(f, identifySIP.SIP.Path, "")) |
There was a problem hiding this comment.
We should remove the initial slash too, so it looks like a relative path. Also for consistency with the changes in #71.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR will remove the absolute path from the
Validate SIP metadata activity.Continuation of: #59 (comment)
Previously:
Now:
