From a2f0a2488cf69f32dc0e7bc218560b3c1c8b955e Mon Sep 17 00:00:00 2001 From: David Juhasz Date: Fri, 20 Sep 2024 09:14:33 -0700 Subject: [PATCH] Bump golangci-lint version 1.58.1 -> 1.61.0 - Upgrade golangci-lint to 1.61.0 for compatiblity with go v1.23.1 - Address gosec G115 integer overflow warnings --- hack/make/dep_golangci_lint.mk | 2 +- internal/bundler/bundler_test.go | 2 +- internal/persistence/ent/client/client_test.go | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hack/make/dep_golangci_lint.mk b/hack/make/dep_golangci_lint.mk index e69e83e3a..1a4335135 100644 --- a/hack/make/dep_golangci_lint.mk +++ b/hack/make/dep_golangci_lint.mk @@ -5,7 +5,7 @@ $(call _assert_var,UNAME_ARCH) $(call _assert_var,CACHE_VERSIONS) $(call _assert_var,CACHE_BIN) -GOLANGCI_LINT_VERSION ?= 1.58.1 +GOLANGCI_LINT_VERSION ?= 1.61.0 ARCH := $(UNAME_ARCH) ifeq ($(UNAME_ARCH),x86_64) diff --git a/internal/bundler/bundler_test.go b/internal/bundler/bundler_test.go index 193763a54..71dd37daf 100644 --- a/internal/bundler/bundler_test.go +++ b/internal/bundler/bundler_test.go @@ -44,7 +44,7 @@ func TestNewBundlerWithTempDir(t *testing.T) { dir := transferDir(t, tmpDir.Path()) assert.Equal(t, b.FullBaseFsPath(), dir) - umask := os.FileMode(syscall.Umask(0)) + umask := os.FileMode(syscall.Umask(0)) // #nosec G115 dirMode := fs.WithMode(0o755 &^ umask) fileMode := fs.WithMode(0o664 &^ umask) diff --git a/internal/persistence/ent/client/client_test.go b/internal/persistence/ent/client/client_test.go index ffb6072f1..5ed778d2f 100644 --- a/internal/persistence/ent/client/client_test.go +++ b/internal/persistence/ent/client/client_test.go @@ -42,7 +42,7 @@ func createPackage( SetWorkflowID("12345"). SetRunID(runID). SetAipID(aipID). - SetStatus(int8(status)). + SetStatus(int8(status)). // #nosec G115 -- constrained value. Save(context.Background()) } @@ -54,7 +54,7 @@ func createPreservationAction( return entc.PreservationAction.Create(). SetWorkflowID("12345"). SetType(int8(enums.PreservationActionTypeCreateAip)). - SetStatus(int8(status)). + SetStatus(int8(status)). // #nosec G115 -- constrained value. SetPackageID(pkgID). Save(context.Background()) }