added week and quarter to persian/farsi #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1190 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2324 2324
Branches 357 357
=========================================
Hits 2324 2324 ☔ View full report in Codecov by Sentry. |
jadchaar
approved these changes
Oct 18, 2024
|
Thanks @Crimson-Amir for the contribution. Mind adding some unit tests? |
jadchaar
approved these changes
Oct 19, 2024
|
@Crimson-Amir would it be possible to add some unit tests? Then we can merge this in. |
|
Sure |
|
Hey @Crimson-Amir thanks for adding tests. Mind running |
krisfremen
approved these changes
Oct 21, 2024
| assert self.locale._format_timeframe("hours", 2) == "2 ساعت" | ||
| assert self.locale._format_timeframe("days", 2) == "2 روز" | ||
| assert self.locale._format_timeframe("weeks", 2) == "2 هفته" | ||
| assert self.locale._format_timeframe("months", 2) == "2 ماه" |
There was a problem hiding this comment.
missing tests for quarters, otherwise 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no equivalent of week and quarter in Persian language.
I use this library and I had to use try-except to handle the week and this made me do this contribute.