Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text color issue in menu #147

Closed
ianbrandt opened this issue Apr 4, 2023 · 3 comments · Fixed by #158
Closed

Text color issue in menu #147

ianbrandt opened this issue Apr 4, 2023 · 3 comments · Fixed by #158
Assignees
@calvellido

Comments

@ianbrandt
Copy link

The "Quikstart" entry is white on a light gray background, so rather hard to see.

https://arrow-kt.io/learn/quickstart/

image
@calvellido calvellido self-assigned this Apr 4, 2023
@calvellido
Copy link
Member

Thanks @ianbrandt, I have this and some other responsive fixes in a branch that I plan to submit later today!

@serras
Copy link
Member

serras commented Apr 5, 2023

Interesting, because I have the opposite problem now: the color of the heading in the menus are too dark.
Captura de pantalla 2023-04-05 a las 9 20 10

@calvellido
Copy link
Member

This is being worked on, thanks!

@calvellido calvellido mentioned this issue Apr 5, 2023
Merged
nomisRev pushed a commit that referenced this issue Apr 5, 2023
@calvellido
Adjust custom CSS specificity affected by Infima (#158)
b4ab2e7 
### Description

This PR make some changes on some selectors' specificity. Due to the way
Docusaurus build production styles, this could sometimes create a
problem through the CSS injection order, making some Infima styles
override custom ones. To overcome this, we are using a subtle trick by
duplicating the class in our CSS, to increase the specificity of our
selectors.

It doesn't seem like an easy task to solve in general for Docusaurus.
More info in: facebook/docusaurus#3678

It also adds proper styling for the Table of Contents on mobile.

This closes #147

### Preview


![imagen](https://user-images.githubusercontent.com/7753447/230122746-a8eb2d3d-f70b-4bb1-92b2-1ea06ca65563.png)

![imagen](https://user-images.githubusercontent.com/7753447/230122431-ddd3dd06-5b06-4e8b-a91e-1aae1723e5f2.png)
@calvellido calvellido mentioned this issue Apr 5, 2023
Merged
calvellido added a commit that referenced this issue Apr 6, 2023
@calvellido
Add syndication links to blog listing page (#159)
bf584ef 
### Description

This PR adds a small section with syndication links to the blog posts
listing page.

It also removes some `TODO` code that has deemed to be not successful
for what we wanted to. Basically, after submitting an issue to one of
our library dependencies, I thought that by the uses of the CSS Modules
`composes` feature, we could avoid the CSS injection order problem
present in:

#147
#158
facebook/docusaurus#3678

But it doesn't seem to be the case, so we are in the need of the use of
the double selector trick to successfully override some Infima selectors
styling with our classes.

This closes #153

### Preview


![imagen](https://user-images.githubusercontent.com/7753447/230139114-f5ef7faa-5988-4871-8dd9-60b91caf2352.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calvellido calvellido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust custom CSS specificity affected by Infima arrow-kt/arrow-website
3 participants
@serras @ianbrandt @calvellido