feat(#199): Adds package annotation for affected tests #258
Conversation
lordofthejars
force-pushed
the
issue_199
branch
from
074b51a to
40b79b9
Compare
There was a problem hiding this comment.
Great stuff @lordofthejars. Few minor things you could fix in between the conferences ;)
|
|
||
| } | ||
|
|
||
| private ComponentUnderTest[] getAllAnnotations(JavaClass testJavaClass) { |
There was a problem hiding this comment.
Minor detail - fix it when you will find time - instead of generic getAllAnnotations - findComponentsUnderTests?
| } | ||
| } | ||
| } | ||
|
|
||
| private void addToIndex(JavaElement javaElement, String[] imports) { | ||
| private List<String> calculateManualAddedDependencies(JavaClass testJavaClass) { |
There was a problem hiding this comment.
calculateManualAddedDependencies -> calculateManuallyAddedDependencies
|
|
||
| JavaAssistClass(CtClass classReference) { | ||
| imports = findImports(classReference); | ||
| className = classReference.getName(); | ||
| this.classReference = classReference; |
There was a problem hiding this comment.
For consistency can we prefix all with this.?
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Target(ElementType.TYPE) | ||
| @Documented | ||
| public @interface ComponentsUnderTest { |
There was a problem hiding this comment.
There is no javadoc nor documentation description
There was a problem hiding this comment.
It's implicitly used for Java8+ as @repeatable annotation, and we don't really support any lower version of JDK right now
There was a problem hiding this comment.
We document the use of the main annotation though https://github.com/arquillian/smart-testing/pull/258/files#diff-10bc48a187b42a0137c1e00172ee76bfR8
There was a problem hiding this comment.
Yeah, I know. I just thought that it would be nice to have an example/doc of this annotation as well. But I don't really insist on it ;-)
Short description of what this resolves:
Adds package annotation for affected tests
Changes proposed in this pull request:
Adds
@ComponentUnderTestannotation to set which production classes are affected by annotated tests. Useful for black box testing.Adds library to scan classes of given package. It is a really light library (no external dependencies), offers a lot of operations that we might use in the future. Also maybe it can be used as a substitution of Javassist.
Fixes #199