Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEBUG_LEVEL env variable is overridden by default config #109

Open
pselden opened this issue Oct 6, 2020 · 0 comments
Open

DEBUG_LEVEL env variable is overridden by default config #109

pselden opened this issue Oct 6, 2020 · 0 comments

Comments

@pselden
Copy link

pselden commented Oct 6, 2020

Repro steps:

  1. Change the deployment to use:
env:
- name: DEBUG_LEVEL
   value: TRACE
  1. Restart Dinghy
  2. Observe in the logs that it is still using INFO

This is because

dinghy/cmd/dinghy.go

Line 71 in 3c33937

logLevelStr := util.GetenvOrDefault("DEBUG_LEVEL", "info")
right afterwards it checks for the settings in the config file. However there's a default of INFO set for that, so it will never be unset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pselden