Defaulting last statusChange for pending pods to CreationTimestamp #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We know as the pod is in pending, that if no conditions have changed, the last thing that happened must have been creation. This change is mostly to allow identification of pods that have got stuck in pending but with no events. - If a pod gets stuck in pending and never gets an event, currently we'll never delete it This change just means if it gets truly stuck in pending, we'll clean it up based on being a long time since it was created.
jankaspar
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know as the pod is in pending, that if no conditions have changed, the last thing that happened must have been creation.
This change is mostly to allow identification of pods that have got stuck in pending but with no events.
This change just means if it gets truly stuck in pending, we'll clean it up based on being a long time since it was created.