Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement core::ops::Shl for BigInt in place of BigInt::muln() #738

Closed
hdvanegasm opened this issue Dec 20, 2023 · 0 comments · Fixed by #739
Closed

Implement core::ops::Shl for BigInt in place of BigInt::muln() #738

hdvanegasm opened this issue Dec 20, 2023 · 0 comments · Fixed by #739

Comments

@hdvanegasm
Copy link
Contributor

This issue follows the same rationale from #714. My proposal is to deprecate BigInt::muln() and replace it for core::ops::Shl. I propose that, in case of overflow, the functionality saturates the result to the highest bit as BigInt::muln() does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant