Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt standard software management practices i.e. dependency versioning #238

Closed
jon-chuang opened this issue Mar 20, 2021 · 5 comments
Closed

Comments

@jon-chuang
Copy link
Contributor

It is fairly weird that we are utilising master as the version for downstream dependencies. Perhaps the rationale is that we are not at a release stage of the project yet. Still, it seems wise to start maintaining branches of release versions and in addition to a breakage-prone master? Especially since arkworks is actually being deployed.

@ValarDragon
Copy link
Member

We're actually working on getting releases out for all the crates right now haha. We ideally should have everything in place to make a release in a couple days

@jon-chuang
Copy link
Contributor Author

Ooh awesome!

@weikengchen
Copy link
Member

weikengchen commented Mar 20, 2021

Basically, or ideally, these repos releases would be on crates.io, and people no longer point to GitHub.

@Pratyush
Copy link
Member

Pratyush commented Mar 20, 2021

Right, the main blocker is arkworks-rs/std#29, and the corresponding downstream PRs. I plan to merge these ASAP.

@ValarDragon
Copy link
Member

Releases are out! Closing this for now, please open new issues if theres any other software development practice's you'd recommend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants