Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Examples/ -> examples/ #26

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Rename Examples/ -> examples/ #26

merged 3 commits into from
Jul 26, 2023

Conversation

sksat
Copy link
Member

@sksat sksat commented Jul 25, 2023 •
edited
Loading

概要

Examples ディレクトリを examples に rename する

Issue

検証結果

CI が通ればよし

影響範囲

  • c2a-core のみ
    • c2a-core 開発者は setup script をやり直す必要がある

補足

そのうち cargo run --example できるようにしたい

@sksat sksat added documentation Improvements or additions to documentation enhancement New feature or request priority::high priorityg high tools labels Jul 25, 2023
@sksat sksat self-assigned this Jul 25, 2023
@sksat sksat requested a review from meltingrabbit July 25, 2023 12:23
@sksat
Copy link
Member Author

sksat commented Jul 25, 2023

develop branch 以外でコードを参照してるドキュメントについては修正してないです

@meltingrabbit
Copy link
Member

develop branch 以外でコードを参照してるドキュメント

#### コマンド配送におけるルーティングについて
- コマンドの最終的な配送先，つまり実行されるボードは APID によって規定される
    - https://github.com/arkedge/c2a-core/blob/45d78a05c339c285b5aa0c2fcbf57c1b105137e9/Examples/mobc/src/src_user/Settings/TlmCmd/Ccsds/apid_define.h#L11-L28

こういうのってこと？

meltingrabbit
meltingrabbit reviewed Jul 26, 2023
View reviewed changes
Script/CI/check_encoding.json
@@ -37,6 +37,6 @@
"Library/",
"System/",
"TlmCmd/",
"Examples/mobc/src/src_user/"
"examples/mobc/src/src_user/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subobc 漏れてるな．．．これどうしよ（流石に別PRか）

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

それは思ったけど，流石に別

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#27 で

@sksat
Copy link
Member Author

sksat commented Jul 26, 2023

そういうやつです．特定 commit のコードを参照してるやつ． > develop branch 以外でコードを参照してるドキュメント

@meltingrabbit
Copy link
Member

labelのtoolsけしていい？（なんでついてるんだっけ？）

@sksat
Copy link
Member Author

sksat commented Jul 26, 2023

Actions workflow と check script もあるから入れてた > tools label

@sksat sksat merged commit 9ccdca8 into develop Jul 26, 2023
@sksat sksat deleted the feature/rename-examples-dir branch July 26, 2023 04:04
@meltingrabbit meltingrabbit mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltingrabbit meltingrabbit meltingrabbit approved these changes

Assignees

@sksat sksat

Labels
documentation Improvements or additions to documentation enhancement New feature or request priority::high priorityg high tools
Projects
C2A public
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sksat @meltingrabbit