Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sils-runtime: require c2a-core v4 #133

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

sksat
Copy link
Member

@sksat sksat commented Oct 12, 2023

概要

c2a-sils-runtime crate で要求する c2a-core(crate)のバージョン指定を major version のみにする

詳細

特定の c2a-core minor, patch version によらずに c2a-sils-runtime crate を使えるようになる

検証結果

CI が通ればよし

影響範囲

これにより,c2a-sils-runtime crate で bindgen 経由で用いている C2A の関数群は major version で維持しなければならないインターフェースとなる(semver のバージョン判断をする API として扱うことになる)

補足

beta release は major version のみの指定では扱えないので,v4.0.0 のリリース以降

@sksat sksat added the enhancement New feature or request label Oct 12, 2023
@sksat sksat self-assigned this Oct 12, 2023
@sksat sksat mentioned this pull request Nov 2, 2023
8 tasks
@sksat
Copy link
Member Author

sksat commented Nov 2, 2023

v4.0.0 がリリースされたのでやる

@sksat sksat force-pushed the feature/specify-c2a-core-major-version-in-sils-runtime branch from de5f7ba to d81a7dd Compare November 2, 2023 06:01
@sksat sksat added this to the v4.1.0 milestone Nov 2, 2023
@sksat
Copy link
Member Author

sksat commented Nov 2, 2023

あー,これ links = 側で無理なのか.まあそうかも.

@sksat sksat force-pushed the feature/specify-c2a-core-major-version-in-sils-runtime branch from d81a7dd to 10a4954 Compare November 9, 2023 10:01
@sksat
Copy link
Member Author

sksat commented Nov 9, 2023

#199 が先なので,v4.2.0 かも

@sksat sksat removed this from the v4.1.0 milestone Nov 9, 2023
@sksat sksat added this to the v4.2.0 milestone Nov 24, 2023
@meltingrabbit meltingrabbit changed the base branch from develop to main December 11, 2023 08:51
@sksat
Copy link
Member Author

sksat commented Dec 12, 2023

rebase

@sksat sksat force-pushed the feature/specify-c2a-core-major-version-in-sils-runtime branch from 10a4954 to c6b7904 Compare December 12, 2023 08:02
@sksat sksat marked this pull request as ready for review December 12, 2023 08:05
@sksat sksat requested a review from meltingrabbit December 25, 2023 10:09
@sksat sksat force-pushed the feature/specify-c2a-core-major-version-in-sils-runtime branch from c6b7904 to dd27e23 Compare December 25, 2023 10:53
@sksat
Copy link
Member Author

sksat commented Dec 25, 2023

rebase

@sksat sksat merged commit 13bac45 into main Dec 25, 2023
@sksat sksat deleted the feature/specify-c2a-core-major-version-in-sils-runtime branch December 25, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants