-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sils-runtime: require c2a-core v4 #133
Merged
sksat
merged 1 commit into
main
from
feature/specify-c2a-core-major-version-in-sils-runtime
Dec 25, 2023
Merged
sils-runtime: require c2a-core v4 #133
sksat
merged 1 commit into
main
from
feature/specify-c2a-core-major-version-in-sils-runtime
Dec 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4.0.0 がリリースされたのでやる |
de5f7ba
to
d81a7dd
Compare
あー,これ |
d81a7dd
to
10a4954
Compare
#199 が先なので,v4.2.0 かも |
rebase |
10a4954
to
c6b7904
Compare
meltingrabbit
approved these changes
Dec 25, 2023
c6b7904
to
dd27e23
Compare
rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
c2a-sils-runtime
crate で要求するc2a-core
(crate)のバージョン指定を major version のみにする詳細
特定の c2a-core minor, patch version によらずに
c2a-sils-runtime
crate を使えるようになる検証結果
CI が通ればよし
影響範囲
これにより,
c2a-sils-runtime
crate で bindgen 経由で用いている C2A の関数群は major version で維持しなければならないインターフェースとなる(semver のバージョン判断をする API として扱うことになる)補足
beta release は major version のみの指定では扱えないので,v4.0.0 のリリース以降