Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

PhantomJS2.0, QFontMEtrics::width with default font on OS X 10.10 problem #12918

Closed
rdpanek opened this issue Jan 29, 2015 · 30 comments
Closed

Comments

@rdpanek
Copy link

rdpanek commented Jan 29, 2015

Have a good day.

OS: Yosemite 10.10.1
Phantomjs2.0: (a2912c2)

My test is stopped when an error:

Assertion failed: (_consumed <= scratch_size), function _hb_coretext_shape, file src/hb-coretext.cc, line 764.
Abort trap: 6

and I found a possible cause:
https://bugreports.qt.io/browse/QTBUG-39504

How and when updates QTWebkit after resolved some bugs via QT team?

In phantomjs 1.9.7 is it OK

@sodabrew
Copy link
Contributor

@ashkulz Has had recent success moving patches through the Qt code review process. Can you take a look at https://codereview.qt-project.org/#/c/87665/ and advise if we should be testing that patch and trying to revive the patch progress?

@ashkulz
Copy link
Contributor

ashkulz commented Feb 2, 2015

This was merged in a separate change as qt/qtbase@abcea1c -- upgrading to Qt 5.4 or cherry-picking that specific change should be enough to fix the issue.

@rdpanek
Copy link
Author

rdpanek commented Feb 4, 2015

@sodabrew @ashkulz Thanks :-) this patch is functional.

@rdpanek rdpanek closed this as completed Feb 4, 2015
@sodabrew
Copy link
Contributor

sodabrew commented Feb 4, 2015

Could we keep this issue open until it is resolved in PhantomJS proper?

@rdpanek
Copy link
Author

rdpanek commented Feb 4, 2015

I agree, I'm sorry

@rdpanek rdpanek reopened this Feb 4, 2015
@matAtWork
Copy link

Exact same issue - OSX 10.10.1. Phantom 2.0.0. Did this patch make it into a release/stable build?

@ashkulz
Copy link
Contributor

ashkulz commented Mar 10, 2015

Not sure if @rdpanek submitted a PR for this.

@ccgagnon
Copy link

Hi, I am running phantomjs by building it form the yosemite branch, but it would be nice to have that fix merged with the 2.0 branch of @ariya repo. When are you planning to do a PR @rdpanek?

@vitallium
Copy link
Collaborator

This issue will be fixed with the next Qt upgrade to 5.4.1

@ashkulz
Copy link
Contributor

ashkulz commented May 7, 2015

@vitallium: I would recommend that Qt be upgraded to 5.4.2 instead, will be released within a week's time.

@lillieatwork
Copy link

Hi @vitallium & @ashkulz! Thank you for your work on this.

We're running into this same issue and were wondering what the status was on the Qt upgrade?

@vitallium
Copy link
Collaborator

@lillieatwork waiting to merge - #13216

@jakoblind
Copy link

Hi, I seem to have the same issue. What's the status?

@wflanagan
Copy link

still waiting on this as a fix as well.. FYI.

@wflanagan
Copy link

Hi all (@vitallium and @ashkulz in particular). Seeing that this was merged, I compiled yesterday based on the current master. This error still occurs, at least in that I get the following error:

Assertion failed: (_consumed <= scratch_size), function _hb_coretext_shape, file src/hb-coretext.cc, line 764

This is different than reported in this ticket, but the same as another ticket that was merged into this one.

@AngelaO
Copy link

AngelaO commented Aug 11, 2015

Hi there, I built from the current master last week and still get the following error (only during some calls to phantomjs, not all the time):

Assertion failed: (_consumed <= scratch_size), function _hb_coretext_shape, file src/hb-coretext.cc, line 764

I'm using OSX 10.10.3

Thanks

@dbrans
Copy link

dbrans commented Aug 19, 2015

+1. I'm running into the same issue.

@MasazI
Copy link

MasazI commented Aug 28, 2015

I have the same issue.

Assertion failed: (_consumed <= scratch_size), function _hb_coretext_shape, file src/hb-coretext.cc, line 764.

@dbrans
Copy link

dbrans commented Aug 28, 2015

Rebuilding phantomjs from source fixed the issue for me.

@adibbehjat
Copy link

Seconding @dbrans solution. Rebuilding the binary has helped solved the problem. Took a bit of time to finish the job, but it did the job.

@travsul
Copy link

travsul commented Sep 3, 2015

I have tried rebuilding the source and I'm still receiving the same error afterwards.

@AngelaO
Copy link

AngelaO commented Sep 4, 2015

I've also tried rebuilding from source and still get the same error

@danielpuglisi
Copy link

+1

@peetucket
Copy link

+1 (with PhantomJS 2.0 on OS X 10.10.5, Ruby 2.2.2)

@talsafran
Copy link

+1 (with PhantomJS 2.0 on OS X 10.10.1, Ruby 2.2.3p173)

@dailystore
Copy link

I'm sorry but what does +1 mean? I'm running into the same issue here. (PhantomJS 2.0 on OS X 10.10.5, ruby 2.0.0p481)

Assertion failed: (_consumed <= scratch_size), function _hb_coretext_shape, file src/hb-coretext.cc, line 764.
Abort trap: 6

Thanks!

@mravery
Copy link

mravery commented Oct 13, 2015

@dailystore +1 just means that people are saying that they're "voting" this issue as relevant because they're also encountering the same problem. +1 for me too. Still trying different ways of handling this issue.

@mravery
Copy link

mravery commented Oct 14, 2015

Here's my fix for it. It comes in two parts. First, in order to build on Yosemite (OX 10.10.*) you need the fix for #12630; there is a patch for that. Second you need this patch: https://github.com/rdpanek/phantomjs/commit/a72df6fbdb2ada7b73aa35aef216b559670486c0

Using homebrew I am able to build phantomjs because it has the first patch applied (be sure to brew update and to use brew install --build-from-source phantomjs). But you still need the second patch. You can edit the formula found in /usr/local/Library/Formula/phantomjs.rb.

Here are the lines to add:

patch do
url "https://raw.githubusercontent.com/Homebrew/patches/480b7142c4e2ae07de6028f672695eb927a34875/phantomjs/yosemite.patch"
  # sha256 "f54bd1592185f031552d3ad5c8809ff27e8f3be4f1c05c81b59bf7dbc4a59de1"
  sha256 "b87a08a30ea4f2716028e5dfe17c77475ae6b9acdfb21c3dac944e593e42e7b7"
end
patch do
  url "https://github.com/rdpanek/phantomjs/commit/a72df6fbdb2ada7b73aa35aef216b559670486c0.patch"
  sha256 "72700babeaec47f1a61474495ff736772f5571cb8a913f4b97d3852476a6212e"
end

I had to change the patch for the Yosemite fix because, for some reason, the patch didn't end with 0x0a (i.e. carriage return) and that was throwing off the patching system. I renamed the file appropriately so that homebrew could find it.

Then I uninstalled phantomjs and reinstalled it so that homebrew would pick up the changes set in my new formula. For whatever reason, I was not able to build outside of homebrew.

@PierreAmmeloot
Copy link

Hello,

I use "[email protected]", install with NPM (Node.JS). I am on Mac OSX 10.12.2

I have similar issue:

Assertion failed: (_consumed <= scratch_size), function _hb_coretext_shape, file src/hb-coretext.cc, line 764.
Abort trap: 6

Latest version don't correct this bug?

@ghost ghost removed the 2.0 label Jan 10, 2018
@stale stale bot added the stale label Dec 25, 2019
@stale
Copy link

stale bot commented Dec 28, 2019

Due to our very limited maintenance capacity (see #14541 for more details), we need to prioritize our development focus on other tasks. Therefore, this issue will be automatically closed. In the future, if we see the need to attend to this issue again, then it will be reopened. Thank you for your contribution!

@stale stale bot closed this as completed Dec 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests