Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of util.old contradicts the point of feature detection #50

Open
mynamesleon opened this issue Jul 19, 2016 · 1 comment · May be fixed by #82
Open

Use of util.old contradicts the point of feature detection #50

mynamesleon opened this issue Jul 19, 2016 · 1 comment · May be fixed by #82

Comments

@mynamesleon
Copy link

Feature detection largely came about because checking for browser versions via the user agent string is unreliable. This is for multiple reasons including (as I'm sure you're already aware):

  1. false positives (e.g. Opera and Edge include "chrome" in their user agent string)
  2. Spoofing
  3. Assuming that a certain User Agent is a reliable means of testing things (e.g. some browsers such as UC Browser and Dolphin Browser were available on very old versions of Android, but supported features the default Android browser of the time did not. So checking for that Android version would have been unreliable)

So including it as part of some of your checks seems somewhat contradictory.

@meowsus
Copy link
Collaborator

meowsus commented May 13, 2019

@mynamesleon that's a good point. I'd be in favor of removing this test, since it is unreliable, but it would require a major version change, due to it's breaking nature.

I'm curious of @viljamis's thoughts on this one.

@meowsus meowsus added this to the 2.0.0 milestone May 19, 2019
@meowsus meowsus linked a pull request Sep 21, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants