Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait-on checks strict ssl #228

Closed
Schnueggel opened this issue Apr 16, 2019 · 1 comment
Closed

wait-on checks strict ssl #228

Schnueggel opened this issue Apr 16, 2019 · 1 comment
Assignees
Labels

Comments

@Schnueggel
Copy link

🐛 Bug Report

The new package wait-on checks with strictSSL set to true. Our dev servers have self signed certs. Now test never starts and the server timeout triggers. Perhaps it would be good to set strictSSL: false, which is ok for dev, or give the option to do so

To Reproduce

Use selfsigned endpoint

Expected behavior

I expect that strict ssl checking is disabled or can be disabled for development purpose

Run npx envinfo --system --binaries --npmPackages expect-puppeteer,jest-dev-server,jest-environment-puppeteer,jest-puppeteer,spawnd --markdown --clipboard

Paste the results here:

## System:
 - OS: Linux 4.15 Ubuntu 18.04.2 LTS (Bionic Beaver)
 - CPU: (8) x64 Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz
 - Memory: 1.66 GB / 15.35 GB
 - Container: Yes
 - Shell: 4.4.19 - /bin/bash
## Binaries:
 - Node: 10.15.3 - ~/.nvm/versions/node/v10.15.3/bin/node
 - npm: 6.4.1 - ~/.nvm/versions/node/v10.15.3/bin/npm
## npmPackages:
 - expect-puppeteer: ^4.1.1 => 4.1.1 
 - jest-dev-server: ^4.1.1 => 4.1.1 
 - jest-puppeteer: ^4.1.0 => 4.1.0 
@xiaoyuhen
Copy link
Contributor

hi @Schnueggel

Very sorry about that, the test case is not complete, so I don't handle the strictSSL case.

Please use the v4.1.0 now, and I will fix this issue as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants