Use either expr or govaluate consistently, not both

[scravy]

Summary

Either when: should use antonmedv/expr or depends: and {{# template tags should use Knetic/govaluate.

There should be just one expression language/syntax be used consistently. Personally I'd be in favor of expr, but that matters less to me than to have a consistent developer experience.

Use Cases

when:, depends: and {{# expr template tags. Currently these use different expression syntax, when: uses govaluate, whereas depends: and {{# uses expr. This is confusing and not very maintainable.

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

[alexec]

I agree with this, but i don't know how we'd remove support without breaking users workflows.

[scravy]

Are there any usages of govaluate other than when:? Maybe when: could be deprecated (without removal) and an if: could be introduced which uses antonmedv/expr. This way user workflows using when: with govaluate expressions should continue to work.

[alexec]

I think a new if is a great idea.

[denis-codefresh]

@alexec I would like to work on it. Seems like a good first issue. Could you assign it to me?

[alexec]

@denis-codefresh I think we (i.e. you) should create a new issue for if. We should get @jessesuen to give comment too.

[agilgur5]

Going to close this out as duplicative of #7831 since the decision has been made with multiple maintainers accepting and #7831 is a specific proposal to address it.