Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon container won't be delete if deadline exceeded happen #10029

Closed
2 of 3 tasks
henrywangx opened this issue Nov 14, 2022 · 7 comments
Closed
2 of 3 tasks

daemon container won't be delete if deadline exceeded happen #10029

henrywangx opened this issue Nov 14, 2022 · 7 comments
Labels
area/controller Controller issues, panics area/daemon-steps P3 Low priority problem/more information needed Not enough information has been provide to diagnose this issue. problem/stale This has not had a response in some time type/bug

Comments

@henrywangx
Copy link
Contributor

henrywangx commented Nov 14, 2022

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issues exists when I tested with :latest
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

We use the daemon container of argo workflow, but the workflow happened hang forever sometimes.
The processes workflow:

  1. running computing steps;
  2. delete daemon container when all computing steps finished.

logs:

 level=error msg="error in entry template execution" error="Deadline exceeded"

And I checked source code as bellow, whether ErrDeadlineExceeded the workflow won't be reconciled if workflow only one daemon container in the end unless restart controller?
https://github.com/argoproj/argo-workflows/blob/master/workflow/controller/operator.go#L346-L353

Version

v3.2.6

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

Hard to reproduce.

Logs from the workflow controller

level=error msg="error in entry template execution" error="Deadline exceeded"

Logs from in your workflow's wait container

no useful log

@henrywangx henrywangx changed the title daemon step won't be delete if deadline exceeded happen daemon container won't be delete if deadline exceeded happen Nov 14, 2022
@alexec
Copy link
Contributor

alexec commented Nov 16, 2022

I think we’d need a workflow to reproduce this if we want to investigate it.

@sarabala1979 sarabala1979 added P3 Low priority problem/more information needed Not enough information has been provide to diagnose this issue. labels Nov 21, 2022
@HRusby
Copy link

HRusby commented Dec 21, 2022

To Note, I believe this is the same issue as in #9934 which does have reproducible workflows attached

@stale

This comment was marked as resolved.

1 similar comment
@stale

This comment was marked as resolved.

@stale stale bot added the problem/stale This has not had a response in some time label Jan 22, 2023
@terrytangyuan terrytangyuan removed the problem/stale This has not had a response in some time label Sep 20, 2023
Copy link
Contributor

github-actions bot commented Feb 2, 2024

This issue has been automatically marked as stale because it has not had recent activity and needs more information. It will be closed if no further activity occurs.

@github-actions github-actions bot added the problem/stale This has not had a response in some time label Feb 2, 2024
Copy link
Contributor

This issue has been closed due to inactivity and lack of information. If you still encounter this issue, please add the requested information and re-open.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2024
@agilgur5
Copy link

To Note, I believe this is the same issue as in #9934 which does have reproducible workflows attached

That one doesn't use a daemon container, so would not apply to this issue.

Otherwise that issue is now resolved.

If you're still encountering this, please provide a reproducible Workflow with a daemon on the :latest version

@agilgur5 agilgur5 added the area/controller Controller issues, panics label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Controller issues, panics area/daemon-steps P3 Low priority problem/more information needed Not enough information has been provide to diagnose this issue. problem/stale This has not had a response in some time type/bug
Projects
None yet
Development

No branches or pull requests

6 participants