-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(controller): Get the right resourceName for traefik.io.Fixes #3615 #3759
fix(controller): Get the right resourceName for traefik.io.Fixes #3615 #3759
Conversation
…proj#3615 Signed-off-by: BrunoTarijon <[email protected]>
d7b70f6
to
a253778
Compare
|
Published E2E Test Results 4 files 4 suites 3h 24m 23s ⏱️ For more details on these failures, see this check. Results for commit dd369bc. |
Published Unit Test Results2 174 tests 2 174 ✅ 2m 54s ⏱️ Results for commit dd369bc. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3759 +/- ##
==========================================
+ Coverage 84.23% 84.31% +0.08%
==========================================
Files 154 154
Lines 18021 18025 +4
==========================================
+ Hits 15180 15198 +18
+ Misses 1998 1991 -7
+ Partials 843 836 -7 ☔ View full report in Codecov by Sentry. |
#3759) Signed-off-by: BrunoTarijon <[email protected]>
…proj#3615 (argoproj#3759) Signed-off-by: BrunoTarijon <[email protected]>
When the var(apiGroupToResource) is executed and we set the traefik api to traefik.io, using the cli flag, the value is not yet setted with SetTraefikAPIGroup(). So the value for traefik.io is not in the map. I changed to a function that is only executed when it is called.
This try to fix the #3615 issue.
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.