-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: code coverage for e2e #3740
Conversation
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3740 +/- ##
==========================================
- Coverage 80.27% 78.16% -2.11%
==========================================
Files 156 157 +1
Lines 17964 22501 +4537
==========================================
+ Hits 14420 17588 +3168
- Misses 2631 3999 +1368
- Partials 913 914 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* first pass at coverage for e2e Signed-off-by: Zach Aller <[email protected]> * change folder names Signed-off-by: Zach Aller <[email protected]> * only upload latest e2e results Signed-off-by: Zach Aller <[email protected]> * change name of step Signed-off-by: Zach Aller <[email protected]> * fix matrix name Signed-off-by: Zach Aller <[email protected]> * rename files Signed-off-by: Zach Aller <[email protected]> * add directory Signed-off-by: Zach Aller <[email protected]> * use correct upload name Signed-off-by: Zach Aller <[email protected]> * move event file Signed-off-by: Zach Aller <[email protected]> * bad move of event_file Signed-off-by: Zach Aller <[email protected]> * fix uncomment Signed-off-by: Zach Aller <[email protected]> * only run on testing workflow Signed-off-by: Zach Aller <[email protected]> * remove events from go workflow Signed-off-by: Zach Aller <[email protected]> * use new download metho Signed-off-by: Zach Aller <[email protected]> * remove specific file Signed-off-by: Zach Aller <[email protected]> * change workflow name Signed-off-by: Zach Aller <[email protected]> * remove double upload Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
* first pass at coverage for e2e Signed-off-by: Zach Aller <[email protected]> * change folder names Signed-off-by: Zach Aller <[email protected]> * only upload latest e2e results Signed-off-by: Zach Aller <[email protected]> * change name of step Signed-off-by: Zach Aller <[email protected]> * fix matrix name Signed-off-by: Zach Aller <[email protected]> * rename files Signed-off-by: Zach Aller <[email protected]> * add directory Signed-off-by: Zach Aller <[email protected]> * use correct upload name Signed-off-by: Zach Aller <[email protected]> * move event file Signed-off-by: Zach Aller <[email protected]> * bad move of event_file Signed-off-by: Zach Aller <[email protected]> * fix uncomment Signed-off-by: Zach Aller <[email protected]> * only run on testing workflow Signed-off-by: Zach Aller <[email protected]> * remove events from go workflow Signed-off-by: Zach Aller <[email protected]> * use new download metho Signed-off-by: Zach Aller <[email protected]> * remove specific file Signed-off-by: Zach Aller <[email protected]> * change workflow name Signed-off-by: Zach Aller <[email protected]> * remove double upload Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
This enables test coverage for e2e tests, I moved unit tests and e2e tests into a single workflow called Testing under the testing.yaml workflow.