Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update golang to 1.21 #3482

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Conversation

blkperl
Copy link
Contributor

@blkperl blkperl commented Mar 29, 2024

Depends on #3458

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented Mar 29, 2024

Go Published Test Results

2 144 tests   2 144 ✅  2m 51s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 32d398b.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.79%. Comparing base (8405f2e) to head (32d398b).
Report is 65 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3482      +/-   ##
==========================================
+ Coverage   81.83%   82.79%   +0.95%     
==========================================
  Files         135      135              
  Lines       20688    17032    -3656     
==========================================
- Hits        16931    14101    -2830     
+ Misses       2883     2041     -842     
- Partials      874      890      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blkperl blkperl marked this pull request as draft March 29, 2024 03:21
@blkperl

This comment was marked as resolved.

Copy link
Contributor

github-actions bot commented Mar 29, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 51m 5s ⏱️
110 tests  99 ✅  6 💤  5 ❌
460 runs  416 ✅ 24 💤 20 ❌

For more details on these failures, see this check.

Results for commit ac2158f.

♻️ This comment has been updated with latest results.

Signed-off-by: william.vanhevelingen <[email protected]>
@blkperl blkperl marked this pull request as ready for review March 29, 2024 19:00
Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.5% Duplication on New Code

See analysis details on SonarCloud

@zachaller zachaller enabled auto-merge (squash) March 29, 2024 19:19
@blkperl blkperl added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Mar 29, 2024
@zachaller zachaller merged commit ea398fc into argoproj:master Mar 29, 2024
22 checks passed
@blkperl blkperl deleted the update_go_1.21 branch March 29, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants