Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo rollouts notifications does not work with telegram #3057

Open
2 tasks done
mishanchus opened this issue Sep 25, 2023 · 3 comments
Open
2 tasks done

Argo rollouts notifications does not work with telegram #3057

mishanchus opened this issue Sep 25, 2023 · 3 comments
Labels
bug Something isn't working no-issue-activity

Comments

@mishanchus
Copy link

Checklist:

  • I've included steps to reproduce the bug.
  • I've included the version of argo rollouts.

Describe the bug
I'm not sure if this is a bug or if I'm doing everything right.
I'm trying to set up notifications with Telegram.
Using the following configuration:

apiVersion: v1
kind: Secret
metadata:
  name: argo-rollouts-notification-secret
stringData:
  telegram-token: "xxxxxxxx"
---
apiVersion: v1
kind: ConfigMap
metadata:
  name: argo-rollouts-notification-configmap
data:
  service.telegram: |
    token: $telegram-token
  template.rollout-completed: |
    message: Rollout {{.rollout.metadata.name}} has been completed.
  trigger.on-rollout-completed: |
    - send: [rollout-completed]
---
apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  name: xxx
  annotations:
    notifications.argoproj.io/subscribe.on-rollout-completed.telegram: "-xxx"

To Reproduce
You must have a telegram bot and use its parameters as in the configuration above.

Expected behavior
After a successful Rollout, the message is sent to Telegram.

Version
quay.io/argoproj/argo-rollouts:v1.6.0

Logs

time="2023-09-22T11:49:33Z" level=error msg="Notifications failed to send for eventReason RolloutCompleted with error: trigger 'on-rollout-completed' is not configured" event_reason=RolloutCompleted namespace=xxx rollout=xxx
time="2023-09-22T11:49:33Z" level=error msg="notification error: Not Found"
time="2023-09-22T11:49:33Z" level=error msg="Notifications failed to send for eventReason RolloutCompleted with error: Not Found" event_reason=RolloutCompleted namespace=xxx rollout=xxx
time="2023-09-22T11:49:33Z" level=info msg="Trigger on-rollout-completed result: []" resource=xxx/xxx
time="2023-09-22T11:49:33Z" level=info msg="Trigger on-rollout-completed result: [{[0].2jmj7l5rSw0yVb_vlWAYkK_YBwk  [rollout-completed] false}]" resource=xxx/xxx

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@mishanchus mishanchus added the bug Something isn't working label Sep 25, 2023
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@kzap
Copy link
Contributor

kzap commented Feb 21, 2024

So unsure if this is related or just invalid config.

@andrii-korotkov-verkada

Should template.rollout-completed section have a telegram key?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity
Projects
None yet
Development

No branches or pull requests

3 participants