fix(metricprovider): Support jsonBody for web metric provider Fixes #2275 #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prema devi Kuppuswamy <[email protected]>
Signed-off-by: Prema devi Kuppuswamy <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 82.38% // Head: 82.37% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2312 +/- ##
==========================================
- Coverage 82.38% 82.37% -0.01%
==========================================
Files 121 121
Lines 18476 18490 +14
==========================================
+ Hits 15221 15232 +11
- Misses 2468 2470 +2
- Partials 787 788 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
6 tasks
zachaller
approved these changes
Oct 14, 2022
zachaller
added
hacktoberfest-accepted
jessesuen
changed the title
premadk
commented
Oct 19, 2022
| Setting a `body` field for a `GET` request will result in an error. | ||
| In order to send in JSON, you can use jsonBody and Content-Type will be automatically set as json. | ||
| Setting a `body` or `jsonBody` field for a `GET` request will result in an error. | ||
| Set either `body` or `jsonBody` and setting both will result in an error. |
There was a problem hiding this comment.
@mayzhang2000 Setting both will result in an error. Should I be removing this line from the doc?
jenciso
pushed a commit
to jenciso/argo-rollouts
that referenced
this pull request
Oct 25, 2022
…rgoproj#2275 (argoproj#2312) * fix(issue2275): Support jsonBody for web metric provider Signed-off-by: Prema devi Kuppuswamy <[email protected]> * fix(webmetrics): generate proto files Signed-off-by: Prema devi Kuppuswamy <[email protected]> Signed-off-by: Prema devi Kuppuswamy <[email protected]>
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 8, 2022
…rgoproj#2275 (argoproj#2312) * fix(issue2275): Support jsonBody for web metric provider Signed-off-by: Prema devi Kuppuswamy <[email protected]> * fix(webmetrics): generate proto files Signed-off-by: Prema devi Kuppuswamy <[email protected]> Signed-off-by: Prema devi Kuppuswamy <[email protected]>
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 26, 2022
…rgoproj#2275 (argoproj#2312) * fix(issue2275): Support jsonBody for web metric provider Signed-off-by: Prema devi Kuppuswamy <[email protected]> * fix(webmetrics): generate proto files Signed-off-by: Prema devi Kuppuswamy <[email protected]> Signed-off-by: Prema devi Kuppuswamy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".