Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: inconsistent urls and broken links #1278

Closed
kostis-codefresh opened this issue Jun 15, 2021 · 1 comment
Closed

Docs: inconsistent urls and broken links #1278

kostis-codefresh opened this issue Jun 15, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@kostis-codefresh
Copy link
Member

(Reported by Bryan Taylor in the CNCF slack channel)

The documentation pages have mixed rendering results where sometimes the extension .html works and sometimes it doesn't

https://argoproj.github.io/argo-rollouts/features/traffic-management/istio/ -> renders a broken page
https://argoproj.github.io/argo-rollouts/features/traffic-management/istio.html -> works ok

But on the other hand

https://argoproj.github.io/argo-rollouts/getting-started/istio/ -> works ok
https://argoproj.github.io/argo-rollouts/getting-started/istio.html -> renders a broken page.

The issue here (apart from the inconsistency) is that the broken links are indexed by Google confusing users.

We should either fix all links to have a consistent rendering or make the wrong ones return 404 instead of broken renderings

problematic-urls


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@kostis-codefresh kostis-codefresh added the bug Something isn't working label Jun 15, 2021
@jessesuen
Copy link
Member

jessesuen commented Jul 3, 2021

Fixed in #1321 and #1322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants