Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check in controller for at least one signal service #55

Closed
magaldima opened this issue Jul 23, 2018 · 0 comments · Fixed by #57
Closed

add check in controller for at least one signal service #55

magaldima opened this issue Jul 23, 2018 · 0 comments · Fixed by #57
Labels
bug Something isn't working
Milestone

Comments

@magaldima
Copy link
Contributor

Describe the bug
Since #49 signals are deployed separate to the sensor-controller. These were added to the hack/k8s/manifests/services directory but as pointed out some users, this fact isn't clearly apparent.

Expected behavior
Signal services are core critical features of sensors so ensuring the services are running as part of argo-events should be a feature of the controller.

Proposal
We should do 3 things:

  1. add a check in the controller for at least one signal service and error out if there is none. We can possibly even take this a step further and incorporate another signal api that allows us to keep track of the possible signal services and periodically check their health. This way, when someone creates a sensor, the controller will know during validation if the need signal services exist for the sensor.
  2. update the docs to say that the signal should be deployed separately.
  3. after 1 and 2, we should perform another pre-release, push up the tagged Docker images for all the built-in components including:
  • argoproj/sensor-controller
  • argoproj/artifact-signal
  • argoproj/calendar-signal
  • argoproj/resource-signal
  • argoproj/webhook-signal
  • argoproj/stream-nats-signal
  • argoproj/stream-kafka-signal
  • argoproj/stream-mqtt-signal
  • argoproj/stream-amqp-signal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant