Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set operation state to nil if new operation has been initiated by a direct object update (#20875) #20915

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Set operation state to nil if new operation has been initiated by a direct object update (#20875) #20915

wants to merge 1 commit into from
+115 −2

Commits on Nov 25, 2024

  1. fix: Set operation state to nil if new operation has been initiated b… 

    …y a direct object update (argoproj#20875)

Fixes argoproj#20875

Some systems like Kargo update the application operation directly to initiate a new sync, bypassing the server. However, they can't update the status operation state to become nil, resulting in discrepancy, see akuity/kargo#2985 and the discussion. Handle this case on the app controller side.

Let's cherry-pick to v2.13.

Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    bb5db09 View commit details
    Browse the repository at this point in the history