-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable automaxprocs logging #20069
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20069 +/- ##
==========================================
+ Coverage 55.95% 55.96% +0.01%
==========================================
Files 322 322
Lines 44544 44715 +171
==========================================
+ Hits 24923 25024 +101
- Misses 17055 17101 +46
- Partials 2566 2590 +24 ☔ View full report in Codecov by Sentry. |
I think that it is useful to log the GOMAXPROCS after it was auto-set by the automaxprocs. |
Signed-off-by: nitishfy <[email protected]> fix lint checks Signed-off-by: nitishfy <[email protected]> move maxprocs to main.go Signed-off-by: nitishfy <[email protected]> move set auto max procs to a function Signed-off-by: nitishfy <[email protected]> add info log Signed-off-by: nitishfy <[email protected]>
Signed-off-by: nitishfy <[email protected]>
Signed-off-by: nitishfy <[email protected]>
Signed-off-by: nitishfy <[email protected]>
@agaudreault can you review the PR now? |
Signed-off-by: nitishfy <[email protected]>
@agaudreault PTAL! |
Signed-off-by: nitishfy <[email protected]>
Head branch was pushed to by a user without write access
* disable automaxprocs logging Signed-off-by: nitishfy <[email protected]> fix lint checks Signed-off-by: nitishfy <[email protected]> move maxprocs to main.go Signed-off-by: nitishfy <[email protected]> move set auto max procs to a function Signed-off-by: nitishfy <[email protected]> add info log Signed-off-by: nitishfy <[email protected]> * add info log Signed-off-by: nitishfy <[email protected]> * fix lint checks Signed-off-by: nitishfy <[email protected]> * fix lint checks Signed-off-by: nitishfy <[email protected]> * add unit test Signed-off-by: nitishfy <[email protected]> * fix lint issues Signed-off-by: nitishfy <[email protected]> --------- Signed-off-by: nitishfy <[email protected]> Signed-off-by: alnoor <[email protected]>
* disable automaxprocs logging Signed-off-by: nitishfy <[email protected]> fix lint checks Signed-off-by: nitishfy <[email protected]> move maxprocs to main.go Signed-off-by: nitishfy <[email protected]> move set auto max procs to a function Signed-off-by: nitishfy <[email protected]> add info log Signed-off-by: nitishfy <[email protected]> * add info log Signed-off-by: nitishfy <[email protected]> * fix lint checks Signed-off-by: nitishfy <[email protected]> * fix lint checks Signed-off-by: nitishfy <[email protected]> * add unit test Signed-off-by: nitishfy <[email protected]> * fix lint issues Signed-off-by: nitishfy <[email protected]> --------- Signed-off-by: nitishfy <[email protected]> Signed-off-by: austin5219 <[email protected]>
/cherry-pick release-2.13 |
/cherry-pick release-2.13 |
* disable automaxprocs logging Signed-off-by: nitishfy <[email protected]> fix lint checks Signed-off-by: nitishfy <[email protected]> move maxprocs to main.go Signed-off-by: nitishfy <[email protected]> move set auto max procs to a function Signed-off-by: nitishfy <[email protected]> add info log Signed-off-by: nitishfy <[email protected]> * add info log Signed-off-by: nitishfy <[email protected]> * fix lint checks Signed-off-by: nitishfy <[email protected]> * fix lint checks Signed-off-by: nitishfy <[email protected]> * add unit test Signed-off-by: nitishfy <[email protected]> * fix lint issues Signed-off-by: nitishfy <[email protected]> --------- Signed-off-by: nitishfy <[email protected]> (cherry picked from commit cfa1c89)
* fix: disable automaxprocs logging (#20069) * disable automaxprocs logging Signed-off-by: nitishfy <[email protected]> fix lint checks Signed-off-by: nitishfy <[email protected]> move maxprocs to main.go Signed-off-by: nitishfy <[email protected]> move set auto max procs to a function Signed-off-by: nitishfy <[email protected]> add info log Signed-off-by: nitishfy <[email protected]> * add info log Signed-off-by: nitishfy <[email protected]> * fix lint checks Signed-off-by: nitishfy <[email protected]> * fix lint checks Signed-off-by: nitishfy <[email protected]> * add unit test Signed-off-by: nitishfy <[email protected]> * fix lint issues Signed-off-by: nitishfy <[email protected]> --------- Signed-off-by: nitishfy <[email protected]> (cherry picked from commit cfa1c89) * fix(ci): ignore temporary files when checking for out of bound symlinks (#20527) Signed-off-by: cef <[email protected]> --------- Signed-off-by: cef <[email protected]> Co-authored-by: Nitish Kumar <[email protected]> Co-authored-by: ABBOUD Moncef <[email protected]>
Closes #20066
Checklist: