Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mutating Manifest for Container Image/Registry #7627

Open
seizadi opened this issue Nov 4, 2021 · 2 comments
Open

Support Mutating Manifest for Container Image/Registry #7627

seizadi opened this issue Nov 4, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@seizadi
Copy link
Contributor

seizadi commented Nov 4, 2021

Summary

We have several changes we make to the helm chart on the cluster to deal with container registry and image issues.
We make these changes on the cluster using mutating hooks. Specifically we use the following:

After post-rendering stage mutations could be made before the rendered manifest is applied to the cluster. These changes also would be part of the logic to compare deployed manifest with Git Repo so that mutations are made before comparison.

Motivation

  • We have use case where we are running our own private repo and want to use third party charts where the container registry is not in the values file to override. The standard helm chart template when created has the registry and image combined:
image:
  repository: nginx
  pullPolicy: IfNotPresent
  # Overrides the image tag whose default is the chart appVersion.
  tag: ""
  • The other problem that the registry-cred webhook address is making sure that the ImagePullSecrets are configured in the namespace. This is needed to make our private registry work with third party charts. In clusters that are not in production and have access to dockerhub we started to experience access issues due to rate limiting changes that took effect recently. So we are configuring an account for dockerhub so that we are not rate limited on access.

Proposal

If these changes are of interest we could evaluate submitting a PR for the changes.

@seizadi seizadi added the enhancement New feature or request label Nov 4, 2021
@seizadi seizadi changed the title Support Mutating Manifest Container Image/Registry Support Mutating Manifest for Container Image/Registry Nov 4, 2021
@jannfis
Copy link
Member

jannfis commented Nov 5, 2021

Could that be handled with something as suggested in #7623?

@seizadi
Copy link
Contributor Author

seizadi commented Nov 5, 2021

Yes it would, I add one comment on requirement. We can close this Issue if we move that one forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants