Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make App diff configMapGenerator aware #2397

Closed
moensch opened this issue Oct 1, 2019 · 7 comments
Closed

Make App diff configMapGenerator aware #2397

moensch opened this issue Oct 1, 2019 · 7 comments
Labels
enhancement New feature or request more-information-needed Further information is requested

Comments

@moensch
Copy link
Contributor

moensch commented Oct 1, 2019

Is your feature request related to a problem? Please describe.
We are using kustomize and configMapGenerator in a fair few places, including the automatic "hash suffix" feature.
In Argo CD in the diff, it always shows this as a "removed file" and an "added file" instead of a diff.
I understand Argo CD literally shows the right stuff (because a brand new resource is being created).

For example, I have this in my kustomization.yaml:

configMapGenerator:
- name: aws-iam-authenticator
  namespace: kube-system
  files:
    - configs/config.yaml

Whenever config.yaml changes, a resource like aws-iam-authenticator-57k69g6486 is being deleted, and a new one like aws-iam-authenticator-97t26c544m is created.

Describe the solution you'd like
It would be cool if it could somehow "understand" that this came from a configMapGenerator and show a nice side-by-side diff off the two resources (even though they have different names).

Have you thought about contributing yourself?
Yes - mostly logging to get input from others and if a solution to this is even feasible.

@moensch moensch added the enhancement New feature or request label Oct 1, 2019
@alexec alexec added help wanted Extra attention is needed kustomize labels Oct 2, 2019
@alexec
Copy link
Contributor

alexec commented Oct 23, 2019

@alexec alexec added more-information-needed Further information is requested and removed help wanted Extra attention is needed labels Oct 23, 2019
@alexmt
Copy link
Collaborator

alexmt commented Oct 23, 2019

I think we were planning to solve the exact same issue by #1636 . @jessesuen , can you please confirm if this is right?

@alexmt
Copy link
Collaborator

alexmt commented Oct 23, 2019

I think @alexec is right. The compare-options: IgnoreExtraneous should keep app in sync status. And GC of old config maps is supposed to be solved by #1636

#1629 (comment)

@no-response
Copy link

no-response bot commented Nov 6, 2019

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@no-response no-response bot closed this as completed Nov 6, 2019
@kplimack
Copy link

kplimack commented Jan 6, 2020

👍

@gaeljw
Copy link
Contributor

gaeljw commented Feb 24, 2022

I'm not sure the suggestions above solve the initial issue/question which (in my understanding) is more about the visual diff in ArgoCD UI.

IgnoreExtraneous flag would just ignore the old resource in the diff but still show a new resource. What we'd like is that the UI is "smarter" and display the actual diff between old resource and new resource as if it was the same resource even though technically on Kubernetes these really are 2 different resources.

@flojon
Copy link

flojon commented Feb 7, 2024

Would be nice to have something similar to how git detects renamed files when showing diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request more-information-needed Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants